Missing tags (again) on Mercurial

13 views
Skip to first unread message

Tony Mechelynck

unread,
Dec 11, 2023, 7:10:14 PM12/11/23
to Christian Brabandt, vim_dev
Something has gone wrong again.

Remember: tags v9.0.2140 to v9.0.2142 had gone missing, but tags
v9.0.2143 to v9.0.2155 had been set correctly. Well, now tags
v9.0.2156 to v9.0.2158 have gone missing again.

This concerns only the Mercurial .hgtags metadata (and I don't know
about any git metadata). In all cases the src/version.c contains the
full list of patch numbers.

Best regards,
Tony.

Christian Brabandt

unread,
Dec 12, 2023, 2:42:04 AM12/12/23
to Tony Mechelynck, vim_dev
Fixed. Not sure why this happened, the script did not receive a tag when
processing the git revision. This could happen, if I push out a new
patch, then the hg-bridge runs and a few moments later the tag is
pushed. However, this shouldn't happen 3 times in a row, so it's a bit
mysterious.

I added some extra logic to parse the subject line in addition when this
happens again.

Thanks,
Christian
--
Avoid contact with eyes.

Tony Mechelynck

unread,
Dec 12, 2023, 3:19:53 AM12/12/23
to Tony Mechelynck, vim_dev
On Tue, Dec 12, 2023 at 8:41 AM Christian Brabandt <c...@256bit.org> wrote:
>
>
> On Di, 12 Dez 2023, Tony Mechelynck wrote:
>
> > Something has gone wrong again.
> >
> > Remember: tags v9.0.2140 to v9.0.2142 had gone missing, but tags
> > v9.0.2143 to v9.0.2155 had been set correctly. Well, now tags
> > v9.0.2156 to v9.0.2158 have gone missing again.
> >
> > This concerns only the Mercurial .hgtags metadata (and I don't know
> > about any git metadata). In all cases the src/version.c contains the
> > full list of patch numbers.
>
> Fixed. Not sure why this happened, the script did not receive a tag when
> processing the git revision. This could happen, if I push out a new
> patch, then the hg-bridge runs and a few moments later the tag is
> pushed. However, this shouldn't happen 3 times in a row, so it's a bit
> mysterious.

IOW, a race condition between the git commit and the hg fetch (or
whatever it is called). Let's hope your fix catches it in the future.
I'll keep eyes peeled in any case.
>
> I added some extra logic to parse the subject line in addition when this
> happens again.
>
> Thanks,
> Christian

My pleasure,
Tony.
Reply all
Reply to author
Forward
0 new messages