[vim/vim] Check Links workflow is not working. (Issue #20040)

[svardew]

svardew created an issue (vim/vim#20040)

Steps to reproduce

Scheduled action Check Links is not working well.
jobs.lychee.steps.'Run Lychee' fails due to ci/lychee.toml :
https://github.com/vim/vim/actions/runs/24620517877/job/71990238413#step:3

Error: OR] Error while loading config: Cannot load configuration file `ci/lychee.toml`: Failed to parse configuration file

Caused by:
    TOML parse error at line 16, column 1
#       |
    16 | retries = 2
       | ^^^^^^^
    unknown field `retries`, expected one of `files_from`, `verbose`, `no_progress`, `host_stats`, `extensions`, `default_extension`, `cache`, `max_cache_age`, `cache_exclude_status`, `dump`, `dump_inputs`, `archive`, `suggest`, `max_redirects`, `max_retries`, `min_tls`, `max_concurrency`, `host_concurrency`, `host_request_interval`, `threads`, `user_agent`, `insecure`, `scheme`, `offline`, `include`, `exclude`, `exclude_file`, `exclude_path`, `exclude_all_private`, `exclude_private`, `exclude_link_local`, `exclude_loopback`, `include_mail`, `remap`, `fallback_extensions`, `index_files`, `header`, `accept`, `include_fragments`, `timeout`, `retry_wait_time`, `method`, `base_url`, `root_dir`, `basic_auth`, `github_token`, `skip_missing`, `no_ignore`, `hidden`, `include_verbatim`, `glob_ignore_case`, `output`, `mode`, `format`, `generate`, `require_https`, `cookie_jar`, `include_wikilinks`, `preprocess`, `hosts`  

lychee program return exit code 3, result no summary report.

correct filed may max_retries.

Expected behaviour

jobs.lychee.steps.'Run Lychee' report lychee summary.

Version of Vim

9.2.0388

Environment

github CI

Logs and stack traces

last run summary
https://github.com/vim/vim/actions/runs/24620517877

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/20040@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#20040)

May be we should drop it again? It has never succeeded and I ignore the lychee report anyhow

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/20040/4300046481@github.com>

[svardew]

svardew left a comment (vim/vim#20040)

modify ci/lychee.toml, and run workflow_dispatch, succesfuly lychee summary reported.
sed -i '/^retries/ s:retries = 2:max_retries = 2:' ci/lychee.toml
gh workflow run link-check.yml --ref my-fix-lychee
https://github.com/svardew/vim/actions/runs/24798010780

then add 'Errors per input' urls to exclude array in ci/lychee.toml, re-run workflow, lychee summary show another errors.
https://github.com/svardew/vim/actions/runs/24879775508

reading 2 summary, simple usage of actions/lychee-action has problems.

• lychee-check errors cause link-check.yml action status as failure. CI send failure report, despite human via web browser can access.
  -- multiple check for a url from documents cause timeout www.gnu.org/licenses/
  -- UGC site (wiki, reddit, etc) return 403 to lychee-bot vim.fandom.com/wiki/Vim_Tips_Wiki
  -- urls in CJK document suffixed with CJK char are not parsed correctly github.com/vim/vim%E3%80%82

• lychee summary report of redirection is too much.
  -- http-to-https redirect
  -- server side hop redirection
  -- site structure change

I think it's difficult to lychee-action check for vim/vim sources keep green CI status.
it is better to run lychee local pc and commit fix-broken-url patch.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/20040/4312411493@github.com>