[vim/vim] Removed auto-set current buffer name as title if no title is provided (PR #19048)

ubaldot

unread,

12:58 AM (5 hours ago) 12:58 AM

to vim/vim, Subscribed

@Konfekt

It seems that it is possible to not specifying the title starting from pandoc 2.7.3 which is quite old.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/19048

Commit Summary

26e0062 Removed auto-set current buffer name as title if no title is provided

File Changes

(1 file)

M runtime/compiler/pandoc.vim (2)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Enno

unread,

3:08 AM (3 hours ago) 3:08 AM

to vim/vim, Subscribed

Konfekt left a comment (vim/vim#19048)

Hello, thank you for finding the exact version where this requirement was dropped; could you give a reference? If it is sufficiently old, we could dispense with a version check

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

ubaldot

unread,

3:42 AM (2 hours ago) 3:42 AM

to vim/vim, Subscribed

ubaldot left a comment (vim/vim#19048)

In-fact we have to go even farther in time: the behavior of throwing a warning instead of an error has been changed in 2.0.6:

https://hackage.haskell.org/package/pandoc-2.0.6/changelog?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Enno

unread,

3:47 AM (2 hours ago) 3:47 AM

to vim/vim, Subscribed

Konfekt left a comment (vim/vim#19048)

Yes, thank you, I was rather referring to a reference for when the warning was dropped

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

ubaldot

unread,

3:55 AM (2 hours ago) 3:55 AM

to vim/vim, Subscribed

ubaldot left a comment (vim/vim#19048)

What about this:

jgm/pandoc#10671

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Enno

unread,

4:07 AM (2 hours ago) 4:07 AM

to vim/vim, Subscribed

Konfekt left a comment (vim/vim#19048)

Thank you! The comment there showing that this has been a nag elsewhere as well. Since the change has only been committed this year to main, could you implement a version check, maybe similar to https://github.com/vim/vim/blob/7a6d9454c8b925c8607b86d7afda2841af2f7f13/runtime/compiler/tombi.vim#L38 ?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Enno

unread,

4:10 AM (2 hours ago) 4:10 AM

to vim/vim, Subscribed

Konfekt left a comment (vim/vim#19048)

By the way, this change has been asked for at another occasion here I think, but I cannot find it anymore

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

ubaldot

unread,

5:31 AM (1 hour ago) 5:31 AM

to vim/vim, Subscribed

ubaldot left a comment (vim/vim#19048)

I can implement a version control in the next days.
However, I don't get why we want to use a newer version to discriminate the auto-inclusion of the title rather than an old one. Does a warning message create many issues?

Also, would that be ok to update the script to Vim9? I think there should already be a number of compiler scripts written in Vim9 if I am not mistaken.