[vim/vim] Always resize when in hit enter prompt (PR #20852)
Foxe Chen
If in a hit enter prompt and the shell size changes, it is supposedly postponed with MODE_SETWSIZE. However that does nothing because its called under the do while loop wait_return(), so the loop does not stop, resulting in Vim screen contents being messed up until some input is received (which causes the loop to stop).
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20852
Commit Summary
- 7b91e59 alwasys resize when in hit enter prompt
File Changes
(1 file)
- M src/term.c (7)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20852)Hm, but that will always clear the hit enter prompt. when resizing while in a hit enter prompt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#20852)Hm, but that will always clear the hit enter prompt. when resizing while in a hit enter prompt
Yes but without clearing the screen, the screen will be messed up on resize meaning you have to clear the screen manually anyways. Maybe it would be better to keep the hit enter prompt when resizing, but this seems like an edge case so im not sure if its worth it
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20852)Hm, it is not quite correct. With your change MODE_SETWSIZE will become unused and I think we need to make a few more changes. Full patch would look like this, I think: https://gist.github.com/chrisbra/9edc20774d3ab63789b30f75c41523a7
This does properly redraw the hit-enter prompt on resize.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#20852)Hm, it is not quite correct. With your change
MODE_SETWSIZEwill become unused and I think we need to make a few more changes. Full patch would look like this, I think: https://gist.github.com/chrisbra/9edc20774d3ab63789b30f75c41523a7This does properly redraw the hit-enter prompt on resize.
The patch doesn't redraw the screen properly when the window size goes from smaller to bigger. I think clearing the screen (and the hit enter prompt) would be the simplest.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20852)The patch doesn't redraw the screen properly when the window size goes from smaller to bigger.
In a terminal you mean? I think that is the best we can do. In the gui it seemed to work for me.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#20852)The patch doesn't redraw the screen properly when the window size goes from smaller to bigger.
In a terminal you mean? I think that is the best we can do. In the gui it seemed to work for me.
I was using the GTK4 GUI, maybe its possibly because of differences in the running Wayland compositor/wm?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20852)let's drop this for now.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.