[vim/vim] Cleanup Tests (PR #12666)

14 views
Skip to first unread message

Christian Brabandt

unread,
Jul 13, 2023, 10:51:10 AM7/13/23
to vim/vim, Subscribed

Clean up temporary left-over files after tests run.

There were a few failures in 'linux (huge, gcc, testgui, true, true)' e.g. here: https://github.com/vim/vim/actions/runs/5497376153/jobs/10018060156

,----
| Error detected while processing command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[585]..function RunTheTest[54]..Test_lvimgrep_crash[16]..TestTimeout[12]..VimLeavePre Autocommands for "*"..function EarlyExit[7]..FinishTesting:
| line 70:
| E445: Other window contains changes
| E937: Attempt to delete a buffer that is in use: Xtest_stable_xxd.txt
| E937: Attempt to delete a buffer that is in use: Xtest_stable_xxd.txt
| E937: Attempt to delete a buffer that is in use: Xtest_stable_xxd.txtmalloc(): unsorted double linked list corrupted
`----

Which is puzzling, because the Xtest_stable_xxd file should have been long gone after test_crypt.vim is run (and definitely no longer be staying around in test_quickfix.vim).

So try to clean up properly after a test script is run, just in case any X is still around. During testing, a found a few leftover files, which I also fixed in the relevant test-file.

Unfortunately, the test workflow 'linux (huge, gcc, testgui, true, true)' now seems to fail with 'E1230: Encryption: sodium_mlock()' in test_crypt.vim. Hopefully this is only temporary hickup :/


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/12666

Commit Summary

File Changes

(3 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/12666@github.com>

codecov[bot]

unread,
Jul 13, 2023, 11:13:21 AM7/13/23
to vim/vim, Subscribed

Codecov Report

Merging #12666 (619c256) into master (16abd99) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #12666   +/-   ##
=======================================
  Coverage   82.09%   82.10%           
=======================================
  Files         160      160           
  Lines      193683   193683           
  Branches    43493    43493           
=======================================
+ Hits       159011   159015    +4     
+ Misses      21824    21821    -3     
+ Partials    12848    12847    -1     
Flag Coverage Δ
huge-clang-none 82.75% <ø> (-0.01%) ⬇️
linux 82.75% <ø> (-0.01%) ⬇️
mingw-x64-HUGE 76.61% <ø> (+<0.01%) ⬆️
mingw-x86-HUGE 77.09% <ø> (-0.01%) ⬇️
windows 78.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/12666/c1634425471@github.com>

Christian Brabandt

unread,
Aug 8, 2023, 2:36:56 PM8/8/23
to vim/vim, Push

@chrisbra pushed 3 commits.

  • ad34abe patch 9.0.1678: blade files are not recognized
  • 9fcde94 Merge pull request #12740 from k-takata/import-9.0.1678
  • 7b067f3 patch 9.0.1679: Cleanup Tests from leftover files


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/12666/push/14606078230@github.com>

Christian Brabandt

unread,
Aug 8, 2023, 2:49:33 PM8/8/23
to vim/vim, Subscribed

was merged, closing


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/12666/c1670125157@github.com>

Christian Brabandt

unread,
Aug 8, 2023, 2:49:37 PM8/8/23
to vim/vim, Subscribed

Closed #12666.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/12666/issue_event/10038964378@github.com>

Reply all
Reply to author
Forward
0 new messages