Commit: patch 9.1.0458: Coverity complains about division by zero

3 views
Skip to first unread message

Christian Brabandt

unread,
Jun 2, 2024, 10:15:12 AM6/2/24
to vim...@googlegroups.com
patch 9.1.0458: Coverity complains about division by zero

Commit: https://github.com/vim/vim/commit/7737ce519b9cba8ef135154d76b69f715b1a0b4d
Author: Christian Brabandt <c...@256bit.org>
Date: Sun Jun 2 16:04:43 2024 +0200

patch 9.1.0458: Coverity complains about division by zero

Problem: Coverity complains about division by zero
Solution: Check explicitly for sw_val being zero

Shouldn't happen, since tabstop value should always be larger than zero.
So just add this as a safety measure.

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/ops.c b/src/ops.c
index fea021b93..b9569571e 100644
--- a/src/ops.c
+++ b/src/ops.c
@@ -233,6 +233,9 @@ shift_line(
int i, j;
int sw_val = trim_to_int(get_sw_value_indent(curbuf, left));

+ if (sw_val == 0)
+ sw_val = 1; // shouldn't happen, just in case
+
count = get_indent(); // get current indent

if (round) // round off indent
diff --git a/src/version.c b/src/version.c
index 221fcf8c7..068c0793c 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 458,
/**/
457,
/**/
Reply all
Reply to author
Forward
0 new messages