[vim/vim] Add the blob2list() and list2blob() functions (#8868)
Yegappan Lakshmanan
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/8868
Commit Summary
- Add the blob2list() and list2blob() functions
File Changes
- M runtime/doc/eval.txt (24)
- M runtime/doc/usr_41.txt (4)
- M src/blob.c (73)
- M src/errors.h (2)
- M src/evalfunc.c (14)
- M src/proto/blob.pro (2)
- M src/proto/typval.pro (1)
- M src/testdir/test_blob.vim (37)
- M src/testdir/test_vim9_builtin.vim (12)
- M src/typval.c (17)
Patch Links:
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub.
Triage notifications on the go with GitHub Mobile for iOS or Android.
codecov[bot]
Codecov Report
Merging #8868 (8da2229) into master (28e591d) will decrease coverage by
87.72%.
The diff coverage is0.00%.
❗ Current head 8da2229 differs from pull request most recent head 4c30b24. Consider uploading reports for the commit 4c30b24 to get more accurate results
@@ Coverage Diff @@ ## master #8868 +/- ## =========================================== - Coverage 90.18% 2.45% -87.73% =========================================== Files 151 149 -2 Lines 170998 165778 -5220 =========================================== - Hits 154221 4077 -150144 - Misses 16777 161701 +144924
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | ? |
|
| huge-gcc-none | ? |
|
| huge-gcc-testgui | ? |
|
| huge-gcc-unittests | 2.45% <0.00%> (-0.01%) |
⬇️ |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/blob.c | 0.00% <0.00%> (-92.56%) |
⬇️ |
| src/evalfunc.c | 0.00% <0.00%> (-96.47%) |
⬇️ |
| src/typval.c | 3.02% <0.00%> (-91.33%) |
⬇️ |
| src/float.c | 0.00% <0.00%> (-99.22%) |
⬇️ |
| src/gui_gtk_f.c | 0.00% <0.00%> (-97.54%) |
⬇️ |
| src/crypt_zip.c | 0.00% <0.00%> (-97.06%) |
⬇️ |
| src/cmdhist.c | 0.00% <0.00%> (-97.03%) |
⬇️ |
| src/match.c | 0.00% <0.00%> (-96.98%) |
⬇️ |
| src/sha256.c | 0.00% <0.00%> (-96.94%) |
⬇️ |
| src/evalbuffer.c | 0.00% <0.00%> (-96.92%) |
⬇️ |
| ... and 140 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 28e591d...4c30b24. Read the comment docs.
Bram Moolenaar
check_for_blob_arg() is only used for Vim9 script, but is then followed by another check for VAR_BLOB.
Looks like when using check_for_blob_arg() always the second check can be dropped.
Similarly for check_for_list_arg() in f_list2blob().
Bram Moolenaar
list2blob() fails if one of the numbers is negative. As it is now, a value over 255 ends up overflowing, taking the lower 8 bits.
I think we should also fail if the number is above 255.
This is a bit strict, I suppose if someone wants to do avoids errors filtering the list first would be the solution.
Bram Moolenaar
Sorry for the confusion, since it was a small change I already added the check for the number value. And give an error message mentioning the invalid number, otherwise there is no clue, other than getting an empty result.
I hope this works OK, otherwise we can still change it.
Yegappan Lakshmanan
Sorry for the confusion, since it was a small change I already added the check for the number value. And give an error message mentioning the invalid number, otherwise there is no clue, other than getting an empty result.
I hope this works OK, otherwise we can still change it.
vim-dev ML
On Tue, Sep 14, 2021 at 1:39 PM Bram Moolenaar ***@***.***>
wrote:
> Sorry for the confusion, since it was a small change I already added the
> check for the number value. And give an error message mentioning the
> invalid number, otherwise there is no clue, other than getting an empty
> result.
> I hope this works OK, otherwise we can still change it.
>
>
>
Your changes look good to me.
Regards,
Yegappan