[vim/vim] Fix restoring incorrect value of w_locked (PR #19728)
Sean Dewar
Problem: w_locked can be bypassed when recursively set if not restored to its prior value.
Solution: rather than save/restore everywhere, just make it a count, like other locks.
You can view, comment on, or merge this pull request online at:
  https://github.com/vim/vim/pull/19728
Commit Summary
- c1520f2 Fix restoring incorrect value of w_locked
File Changes
(6Â files)
- M src/arglist.c (8)
- M src/buffer.c (9)
- M src/ex_cmds.c (4)
- M src/terminal.c (4)
- M src/testdir/test_window_cmd.vim (25)
- M src/window.c (12)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Sean Dewar
seandewar left a comment (vim/vim#19728)Hmm, these failures look like another case of b_nwindows being wrong.
I don't think it's a bug in this change; looks like it uncovered something latent. ðŸ«
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Sean Dewar
@seandewar pushed 2 commits.
- 3003a15 TODO: More places where b_locked_split isn't checked
- a35bb5e Fix restoring incorrect value of w_locked
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Sean Dewar
seandewar left a comment (vim/vim#19728)I think I now know what's wrong with do_ecmd. Tests now pass on my fork, but I still need to look into things more to be completely happy...
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.