[vim/vim] Add runtime files for Jinja and Salt (PR #15689)

10 views
Skip to first unread message

Gregory Anders

unread,
Sep 16, 2024, 12:12:57 PM9/16/24
to vim/vim, Subscribed

Salt is an infrastructure management tool. "Salt state" files are YAML with embedded Jinja for templating.

The Jinja syntax is taken from https://gitlab.com/HiPhish/jinja.vim. This only upstreams the syntax file, which hasn't been modified in 7 years (it's stable).


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/15689

Commit Summary

  • 8acb087 Add syntax file for Jinja
  • 46a9519 Add runtime files for Salt files

File Changes

(4 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15689@github.com>

Christian Brabandt

unread,
Sep 17, 2024, 1:50:12 PM9/17/24
to vim/vim, Subscribed

Thanks. I noticed a few things:

" Maintainer: Gregory Anders
" Upstream: https://gitlab.com/HiPhish/jinja.vim

are you in any kind related to that upstream repo? Just wondering that you are the maintainer, but apparently not using your own repository here?

Also, may I please ask for updates to test_filetype.vim?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15689/c2356553412@github.com>

Gregory Anders

unread,
Sep 17, 2024, 1:53:08 PM9/17/24
to vim/vim, Push

@gpanders pushed 2 commits.

  • ffa7866 Add syntax file for Jinja
  • c1d011d Add runtime files for Salt files


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15689/before/46a9519a430373179a9cbab61fd3895d3c4e8324/after/c1d011d9882f8d8cd41743cd1e799cda785be4dc@github.com>

Gregory Anders

unread,
Sep 17, 2024, 1:55:46 PM9/17/24
to vim/vim, Subscribed

are you in any kind related to that upstream repo? Just wondering that you are the maintainer, but apparently not using your own repository here?

No, not related to the upstream repo. I am only putting myself as maintainer for these files within Vim's runtime (e.g. synchronizing with upstream when necessary, though in this case I don't expect there to be many updates).

Also, may I please ask for updates to test_filetype.vim?

Done so, my mistake.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15689/c2356562673@github.com>

Christian Brabandt

unread,
Sep 17, 2024, 1:56:57 PM9/17/24
to vim/vim, Subscribed

alright thanks!


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15689/c2356564534@github.com>

Christian Brabandt

unread,
Sep 17, 2024, 2:23:44 PM9/17/24
to vim/vim, Subscribed

Closed #15689 via 89b9bb4.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15689/issue_event/14295498055@github.com>

wzy

unread,
9:12 AM (6 hours ago) 9:12 AM
to vim/vim, Subscribed
Freed-Wu left a comment (vim/vim#15689)

Comes from HiPhish/jinja.vim#9

syntax/jinja.vim has been included to vim runtime, however, ftplugin/jinja.vim is missing.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15689/c4866072496@github.com>

Reply all
Reply to author
Forward
0 new messages