[vim/vim] channel.c: Require hostname/address for `ch_listen()` (PR #19799)
zdohnal
This will prevent unintentional binding the process to public network interfaces, and opening Vim to communication from outside network if firewall allows it.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19799
Commit Summary
- 1e522b0 channel.c: Require hostname/address for `ch_listen()`
File Changes
(1 file)
- M src/channel.c (75)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19799)thanks. What is the issue with the indentation change? Also can you please fix the codeql warning? I think the hostname cannot be null anyhow, since you add a test for it right at the beginning.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
zdohnal
@zdohnal pushed 1 commit.
- 5880108 Fix codecov error
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
zdohnal
zdohnal left a comment (vim/vim#19799)hi @chrisbra !
ad indentation - I followed the style in the function - there is 4 space per indent, and every 8 spaces is a tab - I have followed this style in the file and it is why Github shows it that way (so far I have not been able to set Github to show tabs properly - that's why personally prefer using spaces everywhere - everywhere it is shown the same way).
ad codecov error - I have fixed it now.
Thank you for the review!
OT question - is it expected to pass non-localhost address to that function in plugins, or only loopback? I could send PR for enforcing loopback, which could narrow the attack vector further.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19799)That is tricky. I think we should try to restrict to localhost if possible. @mattn does that work for you?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.