[vim/vim] Rename of pum hl_group is incomplete (PR #15348)

zeertzjq

unread,

Jul 25, 2024, 7:00:55 PM (2 days ago) Jul 25

to vim/vim, Subscribed

Problem: Rename of pum hl_group is incomplete.
Solution: Also rename in the test. Rename to user_hlattr in code to
avoid confusion with pum_extra.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/15348

Commit Summary

afa5b68 Rename of pum hl_group is incomplete

File Changes

(5 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 3:44:39 AM (yesterday) Jul 26

to vim/vim, Subscribed

Waiting for #15353

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

glepnir

unread,

Jul 26, 2024, 7:27:05 AM (yesterday) Jul 26

to vim/vim, Subscribed

this name more better

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Jul 26, 2024, 12:20:14 PM (20 hours ago) Jul 26

to vim/vim, Subscribed

thanks, can you please rebase now?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 4:02:21 PM (16 hours ago) Jul 26

to vim/vim, Push

@zeertzjq pushed 1 commit.

fd31464 Rename of pum hl_group is incomplete

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 4:08:39 PM (16 hours ago) Jul 26

to vim/vim, Push

@zeertzjq pushed 1 commit.

18d2603 Rename of pum hl_group is incomplete

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 4:12:26 PM (16 hours ago) Jul 26

to vim/vim, Push

@zeertzjq pushed 1 commit.

c42a199 Rename of pum hl_group is incomplete

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 4:18:31 PM (16 hours ago) Jul 26

to vim/vim, Push

@zeertzjq pushed 1 commit.

1238130 Rename of pum hl_group is incomplete

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 4:22:37 PM (16 hours ago) Jul 26

to vim/vim, Push

@zeertzjq pushed 1 commit.

2f9137f Rename of pum hl_group is incomplete

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 4:35:19 PM (15 hours ago) Jul 26

to vim/vim, Push

@zeertzjq pushed 1 commit.

2abbe35 Rename of pum hl_group is incomplete

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Jul 26, 2024, 7:35:52 PM (12 hours ago) Jul 26

to vim/vim, Push

@zeertzjq pushed 1 commit.

d84d497 Rename of pum hl_group is incomplete

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

7:23 AM (1 hour ago) 7:23 AM

to vim/vim, Subscribed

thanks!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

7:24 AM (1 hour ago) 7:24 AM

to vim/vim, Subscribed

Closed #15348 via 4100852.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward