[vim/vim] scroll: unreachable 'smoothscroll' code in cursor_correct() (PR #20891)
h_east
Problem: cursor_correct() checks for 'smoothscroll' with 'wrap' off, a
combination where 'smoothscroll' has no effect.
Solution: Remove the check, adjust_skipcol() already handles the case where
the cursor line just fits in the window.
Found while auditing the places that reset w_skipcol. The check requires
'wrap' to be off, where 'smoothscroll' has no effect, so it never runs.
Removing it does not change behaviour: 20 cases of 'smoothscroll' with
'nowrap' in a one line window give identical results before and after.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20891
Commit Summary
- 5cb13d0 scroll: unreachable 'smoothscroll' code in cursor_correct()
File Changes
(1 file)
- M src/move.c (13)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20891)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.