[vim/vim] refactor: change boolean gui_T members from int/char to bool (PR #20005)
h_east
Problem:
Several gui_T fields are declared as "int" or "char" but are used strictly as boolean flags with TRUE/FALSE values. The integer types obscure the boolean intent and are wider than needed.
Solution:
Change the following gui_T members to bool (stdbool.h) and update their assignments from TRUE/FALSE to true/false accordingly.
-
int -> bool (11 members): in_focus, in_use, starting, dying, dofork, dospawn, pointer_hidden, force_redraw, directx_enabled, font_can_bold, which_scrollbars[3]
-
char -> bool (2 members): cursor_is_valid, menu_is_active
No existing code compares these members against TRUE/FALSE explicitly (e.g. "== TRUE"), so only plain assignments are affected.
X11 Bool members (rsrc_rev_video, color_approx) are intentionally left unchanged: rsrc_rev_video is registered as an X Toolkit resource with XtRBool / sizeof(Bool) and must keep the int-sized X11 Bool type.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20005
Commit Summary
- 4295660 refactor: change boolean gui_T members from int/char to bool
File Changes
(8 files)
- M src/gui.c (54)
- M src/gui.h (26)
- M src/gui_gtk_x11.c (12)
- M src/gui_motif.c (2)
- M src/gui_w32.c (2)
- M src/gui_x11.c (4)
- M src/main.c (36)
- M src/misc1.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
@h-east pushed 1 commit.
- 85a8348 refactor: change boolean gui_T members from int/char to bool
—
View it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20005)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.