[vim/vim] popup: terminal embedded in an opacity popup freezes Vim on input (PR #20220)

[h_east]

Problem:  When a terminal buffer is shown inside a popup with 'opacity'
          set to a value other than 100, typing into it freezes Vim.
          Only the first keystroke is drawn; afterwards no input is
          processed and the screen stops updating.
Solution: When marking background lines for redraw to keep opacity
          blend cells fresh, do not raise must_redraw.  This marking
          happens from inside update_screen() (via
          may_update_popup_mask()), so raising must_redraw makes
          terminal_loop()'s "while (must_redraw != 0) update_screen()"
          loop never terminate.  Add redraw_win_range_now() that
          updates only the per-window state and use it from
          redraw_win_under_opacity_popup().

Fixes: #20214

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20220

Commit Summary

• 76e5573 popup: terminal embedded in an opacity popup freezes Vim on input

File Changes

(4 files)

• M src/drawscreen.c (22)
• M src/popupwin.c (4)
• M src/proto/drawscreen.pro (1)
• M src/testdir/test_popupwin.vim (26)

Patch Links:

• https://github.com/vim/vim/pull/20220.patch
• https://github.com/vim/vim/pull/20220.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20220@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#20220)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20220/c4460815595@github.com>

[Christian Brabandt]

Closed #20220 via f281493.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20220/issue_event/25580998881@github.com>