[vim/vim] Fix excessive scroll-up with guioptions+=! and ConPTY (PR #19735)
mattn
patch 9.2.0048 (71cc1b1) made ConPTY the default on Windows 11. Since then, running :!cmd (e.g. :!git diff) with guioptions+=! scrolls the screen up by the entire window height, instead of scrolling up only as many lines as the command actually outputs.
The cause is that ConPTY damages (marks dirty) all terminal rows on initialization, even rows that are still empty. This makes tl_dirty_row_end equal to Rows, so the scroll-up loop in update_system_term() keeps scrolling until tl_toprow reaches 0.
The fix uses the terminal cursor position (tl_cursor_pos.row + 1) instead of tl_dirty_row_end for the scroll calculation. The cursor position reflects where content has actually been written, so scrolling is limited to the lines that have real output.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19735
Commit Summary
- 73cb92a Fix excessive scroll-up with guioptions+=! and ConPTY
File Changes
(1 file)
- M src/terminal.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- 3aaf602 Add test for system terminal scroll with guioptions+=!
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
