[vim/vim] Rename digraph functions (related #8580) (#8642)

[h_east]

Changed the function name to have a "digraph_" prefix.

New name	Old name
digraph_get()	getdigraph()
digraph_get_list()	getdigraphlist()
digraph_set()	setdigraph()
digraph_set_list()	setdigraphlist()

--
Best regards,
Hirohito Higashi (h_east)

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/8642

Commit Summary

• Rename digraph functions (related #8580)

File Changes

• M runtime/doc/digraph.txt (2)
• M runtime/doc/eval.txt (211)
• M runtime/doc/usr_41.txt (8)
• M src/digraph.c (48)
• M src/edit.c (2)
• M src/errors.h (4)
• M src/evalfunc.c (16)
• M src/proto/digraph.pro (12)
• M src/testdir/test_digraph.vim (74)

Patch Links:

• https://github.com/vim/vim/pull/8642.patch
• https://github.com/vim/vim/pull/8642.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Maxim Kim]

No sure if get_list is a good suffix, and there are prop_type_list(), popup_list(), etc.

On the other hand there are also bunch of getmarklist(), getjumplist(), getchangelist(), etc.

[Gabriel Dupras]

Just for reference:

Functions with "set" in their name: 39
Functions starting with "set": 23 (59 %)
Functions that do not start with "set": 16 (41 %)

Functions with "get" in their name: 81
Functions starting with "get": 54 (67 %)
Functions that do not start with "get": 27 (33 %)

There is however a lot of functions for newer features that begin with the name of that feature, such as "term", "popup".

I guess it could go either way.

[codecov[bot]]

Codecov Report

Merging #8642 (55b30c8) into master (ff34bee) will decrease coverage by 87.61%.
The diff coverage is 0.00%.

❗ Current head 55b30c8 differs from pull request most recent head 0c90269. Consider uploading reports for the commit 0c90269 to get more accurate results

@@             Coverage Diff             @@

##           master    #8642       +/-   ##

===========================================

- Coverage   90.08%    2.47%   -87.62%     

===========================================

  Files         150      148        -2     

  Lines      169468   164198     -5270     

===========================================

- Hits       152673     4068   -148605     

- Misses      16795   160130   +143335     

Flag	Coverage Δ
huge-clang-none	?
huge-gcc-none	?
huge-gcc-testgui	?
huge-gcc-unittests	2.47% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/digraph.c	0.00% <0.00%> (-94.34%)	⬇️
src/edit.c	0.00% <0.00%> (-92.89%)	⬇️
src/evalfunc.c	0.00% <ø> (-96.40%)	⬇️
src/float.c	0.00% <0.00%> (-98.91%)	⬇️
src/gui_gtk_f.c	0.00% <0.00%> (-97.54%)	⬇️
src/crypt_zip.c	0.00% <0.00%> (-97.06%)	⬇️
src/evalbuffer.c	0.00% <0.00%> (-97.01%)	⬇️
src/sha256.c	0.00% <0.00%> (-96.94%)	⬇️
src/match.c	0.00% <0.00%> (-96.93%)	⬇️
src/cmdhist.c	0.00% <0.00%> (-96.71%)	⬇️
... and 139 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff34bee...0c90269. Read the comment docs.

[lacygoill]

I guess this can be closed since the change seems to have been merged in patch 8.2.3226.

[Christian Brabandt]

Closed #8642.