[vim/vim] filetype: some pbtxt files are not recognized (PR #14463)

Bruno BELANYI

unread,

Apr 9, 2024, 9:39:21 AM4/9/24

to vim/vim, Subscribed

Problem: some textual protocol buffers file extensions are not recognized. Especially, the now officially recommended extension txtpb (see 1).

Solution: add patterns for all extensions that are not strongly discouraged by the documentation.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/14463

Commit Summary

feb48b1 filetype: some pbtxt files are not recognized

File Changes

(1 file)

M runtime/filetype.vim (2)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Bruno BELANYI

unread,

Apr 9, 2024, 9:39:43 AM4/9/24

to vim/vim, Subscribed

Ideally, I think the filetype should be renamed, but that's more of a nitpick.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Apr 9, 2024, 3:37:30 PM4/9/24

to vim/vim, Subscribed

thanks!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Apr 9, 2024, 3:38:51 PM4/9/24

to vim/vim, Subscribed

Can you please update test_filetype.vim?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bruno BELANYI

unread,

Apr 10, 2024, 6:29:09 AM4/10/24

to vim/vim, Push

@ambroisie pushed 1 commit.

9468acd filetype: some pbtxt files are not recognized

—
View it on GitHub.
You are receiving this because you are subscribed to this thread.

Bruno BELANYI

unread,

Apr 10, 2024, 6:29:21 AM4/10/24

to vim/vim, Subscribed

@chrisbra done :-)

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bruno BELANYI

unread,

Apr 10, 2024, 10:18:19 AM4/10/24

to vim/vim, Subscribed

The test failures look unrelated (and mention the test being flaky).

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Apr 10, 2024, 4:34:25 PM4/10/24

to vim/vim, Subscribed

thanks!

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Apr 10, 2024, 4:39:38 PM4/10/24

to vim/vim, Subscribed

Closed #14463 via e54a8e7.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward