[vim/vim] tests: Be sure to delete the "Xm4" test directory (PR #18995)

3 views
Skip to first unread message

MURAOKA Taro

unread,
8:10 AM (13 hours ago) 8:10 AM
to vim/vim, Subscribed

Problem: tests: The "Xm4" directory remains after running test_filetype.vim.

Test_m4_format in test_filetype.vim creates the "Xm4" directory with the 'D' flag. Then it creates two files in the "Xm4" directory. One of them, "alocal.m4," was created with the 'D' flag, so it will disappear after the test is complete. However, the other, "configure.ac," was created without any flags, so it will remain even after the test is complete. Because the parent directory "Xm4" was created with the 'D' flag, the latter "configure.ac" remains and is not empty, so it will not be deleted.

Solution: The 'R' flag is now used when creating the "Xm4" directory.

This forces the directory to be deleted regardless of its contents. As a result,flags for two files "alocal.m4" and "configure.ac" created in the directory are no longer needed, so they have been deleted.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18995

Commit Summary

  • 155dfb9 tests: Be sure to delete the "Xm4" test directory

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18995@github.com>

Christian Brabandt

unread,
1:30 PM (8 hours ago) 1:30 PM
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18995)

thanks


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18995/c3683457993@github.com>

Christian Brabandt

unread,
1:37 PM (7 hours ago) 1:37 PM
to vim/vim, Subscribed

Closed #18995 via de37e74.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18995/issue_event/21710728088@github.com>

Reply all
Reply to author
Forward
0 new messages