[vim/vim] v:register is wrong in v_: command (PR #18597)
zeertzjq
Problem: v:register is wrong in v_: command (after 9.1.1858).
Solution: Revert patch 9.1.1858 for now. Add a test.
related: #18583 (comment)
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18597
Commit Summary
- 929117e v:register is wrong in v_: command
File Changes
(2 files)
- M src/normal.c (16)
- M src/testdir/test_registers.vim (24)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq pushed 1 commit.
- d820f2a v:register is wrong in v_: command
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18597)There is a discussion on the vim-dev mailinglist about a possible uninitialized variable and this PR also shows this:
normal.c: In function ‘normal_cmd’:
normal.c:999:19: warning: ‘did_visual_op’ may be used uninitialized [-Wmaybe-uninitialized]
999 | if (finish_op || did_visual_op)
| ~~~~~~~~~~^~~~~~~~~~~~~~~~
normal.c:972:9: note: ‘did_visual_op’ was declared here
972 | int did_visual_op = FALSE;
| ^~~~~~~~~~~~~
I think we may need to initialize did_visual_op before the various goto normal_end commands.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
zeertzjq left a comment (vim/vim#18597)I've moved it to the top of normal_cmd().
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18597)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.