[vim/vim] refactor comment package to allow simpler tests (PR #20649)

6 views

Skip to first unread message

Maxim Kim

unread,

2:01 AM (3 hours ago) 2:01 AM

to vim/vim, Subscribed

Currently test suite for the comment package uses separate vim in terminal to do tests, which is inefficient and unnecessary complex.

The reason is that comment.Toggle() uses <stack> to get function name for the opfunc and this fools vim's test runner.

use lambda function for opfunc inside comment.Toggle()
simplify tests not to use terminal

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/20649

Commit Summary

9776244 refactor comment package to allow simpler tests

File Changes

(2 files)

M runtime/pack/dist/opt/comment/autoload/comment.vim (90)
M src/testdir/test_plugin_comment.vim (469)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

4:41 AM (1 hour ago) 4:41 AM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#20649)

thanks

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward

0 new messages