[vim/vim] test_sound.vim fails on Windows (PR #18941)
MURAOKA Taro
Problem: tests: test_sound.vim fails when run locally on Windows
Cause: There are two causes.
First. The global variable g:id is undefined, causing an undefined reference. Due to the execution order of test cases, g:id is defined in Test_play_event. However, on Windows, this test is skipped, so g:id is not defined. It is referenced in Test_play_silent's WaitForAssert without being defined, resulting in an undefined error.
Solution: Define g:id at the beginning of Test_play_silent.
Second. In the non-GUI Windows version of vim, there is no message loop, so the callback when play file sound ends does not occur, and Test_play_silent's WaitForAssert times out and fails. In CI, sound_playfile() returns 0, so Test_play_silent is skipped. The reason for this is unknown, but it may be because CI is running on Windows Server or something like that.
Solution: Skip Test_play_silent in Windows non-GUI environments.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18941
Commit Summary
- 7ebc1f4 tests: test_sound.vim fails on Windows
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18941)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.