[vim/vim] Prevent makeTargetinDefine matching extra line (PR #18570)

3 views
Skip to first unread message

littlewu2508

unread,
Oct 14, 2025, 4:00:46 AM (7 days ago) Oct 14
to vim/vim, Subscribed

This fixes a bug introduced in 2a33b49: When makeTargetinDefine ends with makeIdent, makeSpecTarget or makeComment, the following line is also matched as makeTargetinDefine.

So, add keepend to prevent that just as makeTarget does.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18570

Commit Summary

  • 47ad2db Prevent makeTargetinDefine matching extra line

File Changes

(1 file)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18570@github.com>

littlewu2508

unread,
Oct 14, 2025, 4:03:49 AM (7 days ago) Oct 14
to vim/vim, Subscribed
littlewu2508 left a comment (vim/vim#18570)

@rohieb Sorry for bothering again -- just catched a bug I introduced in #18403 :

When makeTargetinDefine ends with makeIdent, makeSpecTarget or makeComment, the following line is also matched as makeTargetinDefine. Here's a simple example:

orig2.png (view on web) orig.png (view on web)

So I add keepend in makeTargetinDefine region, which fixes this:

new.png (view on web)


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18570/c3400575872@github.com>

Roland Hieber

unread,
Oct 20, 2025, 6:18:19 AM (23 hours ago) Oct 20
to vim/vim, Subscribed

@rohieb approved this pull request.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18570/review/3355924040@github.com>

Reply all
Reply to author
Forward
0 new messages