[vim/vim] tests(commondumps): Use character counts when marking columns (PR #20237)
Aliaksei Budavei
Continue using strwidth when calculating the position of
a column of interest, and start using setcharpos when
marking a line of interest so that paired-up marks remain
aligned columnwise across all three parts generated by
term_dumpdiff, especially when multibyte characters are
written in the line before the marked column.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20237
Commit Summary
- 63ee281 tests(commondumps): Use character counts when marking columns
File Changes
(1 file)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Aliaksei Budavei
zzzyxwvut left a comment (vim/vim#20237)We can see the result of counting column positions in bytes
(rather than characters) and falling short of mark alignment
between multibyte and ASCII lines with this example routine:
cd runtime/syntax git switch --detach v9.2.0498 git revert --no-edit -Xours f7e239bd0 make clean sh_functions_bash.sh test ../../src/vim --clean -S testdir/viewdumps.vim # :normal `a # :normal `` # :normal ``
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20237)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.