[vim/vim] Add log syntax file (Issue #18218)
毛逸宁
mao-yining created an issue (vim/vim#18218)The messages syntax file is narrow. I hope there is a log syntax file to enhance vim's log view.
As https://github.com/MTDL9/vim-log-highlighting
Thanks!
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18218)The way to add new runtime files is to ask the author to submit their work here. This way we get explicit permissions to distribute their work and they acknowledge to be upstream maintainer in case of bugs.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
毛逸宁
Closed #18218 as completed.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
毛逸宁
mao-yining left a comment (vim/vim#18218)It seems that the original author had a long time not active on github. Can I submit his work and responsible for maintain it?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
毛逸宁
Reopened #18218.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
毛逸宁
mao-yining left a comment (vim/vim#18218)It seems that the original author had a long time not active on github. Can I submit his work and responsible for maintain it?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18218)It should be okay since his work is distributed under the MIT license. If you are willing to maintain it, best would be to fork the upstream repo, and submit it under your user and then you can also add yourself in the header of the runtime scripts (and point to your repo for questions, issues and improvements). Thanks.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
chdiza
chdiza left a comment (vim/vim#18218)It's not clear to me that there really is such a thing a a "generic log", and thus it is unclear that we want to have Vim automatically treat things with a ".log" suffix as having a specific syntax file activated.
E.g., tex and latex produce files ending in ".log", but it makes no sense for them to be highlighted with the syntax from 9.1.1755.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
dkearns
dkearns left a comment (vim/vim#18218)I think the filetype detection needs to do some work to check that it's an appropriately formatted log file.
The first hundred log files that locate turns up on my system are JSON, for example.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18218)I have been using the above mentioned MTDL9 repo for JSON log files at my work and it helps reading those files. Log is a bit generic in that there could be different syntaxes being used, so it is hard to get it right. I was hoping that this generic format is still being useful by highlighting dates and errors.
But I am fine with further tuning the log file detection logic.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Shane-XB-Qian
Shane-XB-Qian left a comment (vim/vim#18218)i donot think such 'generic' highlight of so called 'log' ft, helped something meaningful:
- vs lots of confusion
- vs slow down perf lot
> But I am fine with further tuning the log file detection logic.
--
shane.xb.qian
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
chdiza
chdiza left a comment (vim/vim#18218)I was hoping that this generic format is still being useful by highlighting dates and errors.
The problem is that it also highlights a bunch of other stuff (e.g., seemingly every single space-flanked number (!!), backslash, or asterisk), which is profoundly distracting for some other legit files that have the suffix "log".
I'm going to carry au BufNewFile,BufRead *.log setf ignored around.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Shane-XB-Qian
Shane-XB-Qian left a comment (vim/vim#18218)Even it was that "legit" log, the perf impacted too much, i donot think it was worthy.
> I'm going to carry `au BufNewFile,BufRead *.log setf ignored` around.
--
shane.xb.qian
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18218)Alright, I'll revert it. I keep the logfile syntax however
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
毛逸宁
Closed #18218 as completed.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.