[vim/vim] Garbled output on serial terminals with XON/XOFF flow control (PR #14542)

13 views
Skip to first unread message

Anton Sharonov (ant0sha)

unread,
Apr 13, 2024, 4:48:40 PM4/13/24
to vim/vim, Subscribed

Problem: When used terminal with XON/XOFF flow control, vim tries to
still make CTRL-S mapping available, which results in severe
screen corruption, especially on large redraws, and even
spurious inputs
Solution: Disallow CTRL-S mapping if such terminal is recognized.
Don't remove IXON from the bitmask inversion.

closes: #12674 (well, at least CTRL-S mapping is disabled, cannot test vt420 corruption because I do not have such hardware)

When started with TERM=vt420:

TERM=vt420 vim

subsequent

:set termcap

shows t_xon=y

mapping

map <C-S> :echo "abc"<CR>

does nothing (after <C-S> output freezes and subsequent <C-Q>
unfreezes it)

When started with TERM=xterm:

TERM=xterm vim

subsequent

:set termcap

shows t_xon=

mapping

map <C-S> :echo "abc"<CR>

works (after <C-S> one see abc string echo-ed)


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/14542

Commit Summary

  • ff2ad4b Garbled output on serial terminals with XON/XOFF flow control

File Changes

(4 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14542@github.com>

Christian Brabandt

unread,
Apr 14, 2024, 2:02:48 PM4/14/24
to vim/vim, Subscribed

thanks, I have made a few minor changes, mostly documentation and tests.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14542/c2054135940@github.com>

Christian Brabandt

unread,
Apr 14, 2024, 2:06:05 PM4/14/24
to vim/vim, Subscribed

Closed #14542 via 49528da.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/14542/issue_event/12460946711@github.com>

Reply all
Reply to author
Forward
0 new messages