[vim/vim] Fix popup window flickering on content-only updates (PR #19559)
mattn
When popup_setoptions() is called to update only firstline (e.g. scrolling via a timer), windows behind the popup flicker because a full popup mask refresh and UPD_NOT_VALID redraw are triggered every time, even though the popup's position and size haven't changed.
This patch distinguishes content-only changes (firstline, highlights) from structural ones (zindex, popup_flags, blend). For content-only changes, skip the mask refresh and popup_adjust_position(), and use UPD_VALID instead of UPD_NOT_VALID so only the popup itself is redrawn.
" Reproducer let s:id = popup_create(range(1, 50)->map({i, v -> $"line {v}"}), { \ 'pos': 'center', 'minwidth': 60, 'maxheight': 10, 'border': [], \ }) let s:n = 1 function! s:scroll(timer) abort let s:n = s:n % 50 + 1 call popup_setoptions(s:id, {'firstline': s:n}) endfunction call timer_start(500, function('s:scroll'), {'repeat': -1})
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19559
Commit Summary
- 77766d7 Fix popup flick
File Changes
(1 file)
- M src/popupwin.c (37)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#19559) Found errors in Test_popup_firstline():
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[636]..function RunTheTest[63]..Test_popup_firstline line 30: Expected 11 but got 10
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[636]..function RunTheTest[63]..Test_popup_firstline line 36: Expected 10 but got 9
command line..script /home/runner/work/vim/vim/src/testdir/runtest.vim[636]..function RunTheTest[63]..Test_popup_firstline line 41: Expected 10 but got 9
Test is failing but I can judge whether the problem is depend on firstline or not.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
mattn
@mattn pushed 1 commit.
- b9f45eb clear POPF_OPACITY if opacity is 100
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#19559)Also, opacity: 100 (fully opaque) now clears the POPF_OPACITY flag so the popup behaves exactly like a normal popup without opacity. The transparency rendering path is only used for opacity: 1-99.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
mattn
mattn left a comment (vim/vim#19559)What this pull request fixes
- Reduces the redraw area when changes are confined to the popup window
- Prevents flickering of the popup window during background scrolling
See #19510
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#19559)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.