[vim/vim] Minor regression in 9.1.1748: unconditional usage of TASK_DEFAULT_APPLICATION breaks build on Leopard (Issue #19044)

[Sergey Fedorov]

barracuda156 created an issue (vim/vim#19044)

Steps to reproduce

Run the build from any tag including this commit: 4bf0f6c

Reference:
10.5 (fails): https://github.com/alexey-lysiuk/macos-sdk/blob/78bd32056afc9a4720580f82d4ac839e7e831b6e/MacOSX10.5.sdk/usr/include/mach/task_policy.h#L106-L113
10.6 (works): https://github.com/alexey-lysiuk/macos-sdk/blob/78bd32056afc9a4720580f82d4ac839e7e831b6e/MacOSX10.6.sdk/usr/include/mach/task_policy.h#L106-L115

Expected behaviour

The build should work, it was broken for no good reason. The function is to be used where it exists.

Version of Vim

9.1.1748

Environment

macOS 10.5.8

Logs and stack traces

error: 'TASK_DEFAULT_APPLICATION' undeclared

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19044@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#19044)

So here it is mentioned that this does not turn up until 10.7? So perhaps a patch like this should work?

diff --git a/src/os_unix.c b/src/os_unix.c
index fdae5d67f..9100a1a23 100644
--- a/src/os_unix.c
+++ b/src/os_unix.c
@@ -3681,8 +3681,10 @@ mch_early_init(void)
      * threads’ quality of service classes clamped.
      */
 #ifdef MACOS_X
+#  ifdef MAC_OS_X_VERSION_10_7
     integer_t policy = TASK_DEFAULT_APPLICATION;
     task_policy_set(mach_task_self(), TASK_CATEGORY_POLICY, &policy, 1);
+# endif
 #endif
 }

Note: I do not know much about MacOS X at all.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/issues/19044/3701886037@github.com>