Commit: patch 9.1.0262: Test for TextChanged is flaky with ASAN

3 views
Skip to first unread message

Christian Brabandt

unread,
Apr 4, 2024, 3:45:11 PM4/4/24
to vim...@googlegroups.com
patch 9.1.0262: Test for TextChanged is flaky with ASAN

Commit: https://github.com/vim/vim/commit/4a65391ca273f2eca84f5ec7bd846693232dfacc
Author: zeertzjq <zeer...@outlook.com>
Date: Thu Apr 4 21:33:36 2024 +0200

patch 9.1.0262: Test for TextChanged is flaky with ASAN

Problem: Test for TextChanged is flaky with ASAN.
Solution: Wait for the file to be non-empty.
(zeertzjq)

closes: #14404

Signed-off-by: zeertzjq <zeer...@outlook.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/testdir/test_autocmd.vim b/src/testdir/test_autocmd.vim
index 3a313ed90..cc1f6cd8d 100644
--- a/src/testdir/test_autocmd.vim
+++ b/src/testdir/test_autocmd.vim
@@ -4486,7 +4486,7 @@ func Test_Changed_ChangedI()
au TextChangedI <buffer> :call TextChangedAutocmd('I')

nnoremap <CR> o<Esc>
- call writefile([''], 'XTextChangedI3')
+ autocmd SafeState * ++once call writefile([''], 'XTextChangedI3')
END

call writefile(before, 'Xinit', 'D')
@@ -4495,6 +4495,7 @@ func Test_Changed_ChangedI()
\ {'term_rows': 10})
call assert_equal('running', term_getstatus(buf))
call WaitForAssert({-> assert_true(filereadable('XTextChangedI3'))})
+ call WaitForAssert({-> assert_equal([''], readfile('XTextChangedI3'))})

" TextChanged should trigger if a mapping enters and leaves Insert mode.
call term_sendkeys(buf, "\<CR>")
diff --git a/src/version.c b/src/version.c
index 450e0d8cf..d31484a4e 100644
--- a/src/version.c
+++ b/src/version.c
@@ -704,6 +704,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 262,
/**/
261,
/**/
Reply all
Reply to author
Forward
0 new messages