[vim/vim] allow get/set tab-local 'cmdheight' via gettabvar()/settabvar() (PR #15713)
Milly
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/15713
Commit Summary
- 0fd2cd8 test: add missing tests
- 5f03d9e test: fix tabpage cmdheight test
- 434a353 feat: get tab-local options by gettabvar()
- 95d6645 feat: set tab-local options by settabvar()
File Changes
(11 files)
- M runtime/doc/builtin.txt (20)
- M src/evalvars.c (27)
- M src/option.c (20)
- M src/option.h (11)
- M src/optiondefs.h (10)
- M src/proto/option.pro (2)
- M src/testdir/dumps/Test_tabpage_cmdheight.dump (4)
- A src/testdir/dumps/Test_tabpage_cmdheight_with_settabvar_1.dump (20)
- A src/testdir/dumps/Test_tabpage_cmdheight_with_settabvar_2.dump (20)
- M src/testdir/test_getvar.vim (23)
- M src/testdir/test_tabpage.vim (30)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq commented on this pull request.
In src/option.h:
> @@ -1339,6 +1339,17 @@ enum
, WV_COUNT // must be the last one
};
+/*
+ * "indir" values for tab-local options.
+ * These need to be defined globally, so that the TV_COUNT can be used in the
TV_COUNT isn't used anywhere
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Milly
@Milly commented on this pull request.
In src/option.h:
> @@ -1339,6 +1339,17 @@ enum
, WV_COUNT // must be the last one
};
+/*
+ * "indir" values for tab-local options.
+ * These need to be defined globally, so that the TV_COUNT can be used in the
Yes. Fix the comment or remove the definition?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
zeertzjq
@zeertzjq commented on this pull request.
In src/option.h:
> @@ -1339,6 +1339,17 @@ enum
, WV_COUNT // must be the last one
};
+/*
+ * "indir" values for tab-local options.
+ * These need to be defined globally, so that the TV_COUNT can be used in the
Actually I think that means the implementation is incomplete. BV_COUNT and WV_COUNT are used for arrays that store script contexts that set local options, so if 'cmdheight' needs to be a fully tab-local option it's necessary to store a script context with the tabpage as well.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Milly
@Milly commented on this pull request.
In src/option.h:
> @@ -1339,6 +1339,17 @@ enum
, WV_COUNT // must be the last one
};
+/*
+ * "indir" values for tab-local options.
+ * These need to be defined globally, so that the TV_COUNT can be used in the
I think that should be done in a separate PR about cmdheight.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
@chrisbra commented on this pull request.
In src/option.h:
> @@ -1339,6 +1339,17 @@ enum
, WV_COUNT // must be the last one
};
+/*
+ * "indir" values for tab-local options.
+ * These need to be defined globally, so that the TV_COUNT can be used in the
Yeah, but we should still remember when this option was (re-)set right?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Milly
@Milly commented on this pull request.
In src/option.h:
> @@ -1339,6 +1339,17 @@ enum
, WV_COUNT // must be the last one
};
+/*
+ * "indir" values for tab-local options.
+ * These need to be defined globally, so that the TV_COUNT can be used in the
I'll write another PR to make cmdheight as a true tab-local option.
And in the meantime I'd like to mark this PR as a WIP.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#15713)this has stalled, so closing
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.