[vim/vim] Avoid using C++ keyword `class` as member variable name (PR #19016)
Wei Tang
Problem: A recent commit introduced a member variable named class in
the exarg structure, which conflicts with the C++ keyword
class. This causes compilation issues on Windows when VIM
is compiled with OLE enabled, as "if_ole.cpp" cannot compile
due to the keyword conflict.
Solution: Rename the member variable of exarg from class to cclass.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/19016
Commit Summary
- aea861a Avoid using C++ keyword `class` as member variable name
File Changes
(3 files)
- M src/eval.c (2)
- M src/ex_cmds.h (2)
- M src/vim9class.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
@yegappan requested changes on this pull request.
The precedence in other places is to use an abbreviation of the structure name as the prefix. So can you use the prefix "ea_" instead of just "c"?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Wei Tang
@Fuzzier pushed 1 commit.
- d0b5794 Avoid using C++ keyword `class` as member variable name
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
Wei Tang
Fuzzier left a comment (vim/vim#19016)The precedence in other places is to use an abbreviation of the structure name as the prefix. So can you use the prefix "ea_" instead of just "c"?
Renamed cclass to ea_class to match the naming convention.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.