[vim/vim] Convert more tests in test49 into new style tests (#6638)

12 views
Skip to first unread message

Yegappan Lakshmanan

unread,
Aug 6, 2020, 1:53:14 AM8/6/20
to vim/vim, Subscribed

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/6638

Commit Summary

  • Convert more tests in test49 into new style tests

File Changes

Patch Links:

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

codecov[bot]

unread,
Aug 6, 2020, 2:32:54 AM8/6/20
to vim/vim, Subscribed

Codecov Report

Merging #6638 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@

##           master    #6638      +/-   ##

==========================================

- Coverage   88.26%   88.26%   -0.01%     

==========================================

  Files         146      146              

  Lines      160256   160256              

==========================================

- Hits       141455   141442      -13     

- Misses      18801    18814      +13
Impacted Files Coverage Δ
src/ui.c 79.83% <0.00%> (-3.82%) ⬇️
src/os_unix.c 71.00% <0.00%> (-0.22%) ⬇️
src/clipboard.c 83.21% <0.00%> (-0.11%) ⬇️
src/gui_gtk_x11.c 58.59% <0.00%> (-0.05%) ⬇️
src/terminal.c 91.02% <0.00%> (+0.03%) ⬆️
src/gui.c 62.75% <0.00%> (+0.04%) ⬆️
src/if_xcmdsrv.c 88.55% <0.00%> (+0.17%) ⬆️
src/mbyte.c 79.45% <0.00%> (+0.24%) ⬆️
src/gui_gtk.c 31.71% <0.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8d732e...feecbe8. Read the comment docs.

Bram Moolenaar

unread,
Aug 6, 2020, 3:13:32 PM8/6/20
to vim/vim, Subscribed

Looks like Test_user_exception_info() is failing on Github CI

Yegappan Lakshmanan

unread,
Aug 6, 2020, 3:36:47 PM8/6/20
to vim/vim, Push

@yegappan pushed 1 commit.

  • 501411b Use only the filename for comparision in the exception info

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

Yegappan Lakshmanan

unread,
Aug 6, 2020, 3:39:15 PM8/6/20
to vim_dev, reply+ACY5DGEC6BXO73RUAB...@reply.github.com, vim/vim, Subscribed
Hi Bram,

On Thu, Aug 6, 2020 at 12:13 PM Bram Moolenaar <vim-dev...@256bit.org> wrote:

Looks like Test_user_exception_info() is failing on Github CI



The test failed on Windows because it was comparing an abbreviated filename
(C:/Users/RUNNER~1/AppData/Local/Temp/VIMB159.tmp) with an expanded
filename (C:/Users/runneradmin/AppData/Local/Temp/VIPB17A.tmp).

I have pushed a fix for this.

- Yegappan 

vim-dev ML

unread,
Aug 6, 2020, 3:39:25 PM8/6/20
to vim/vim, vim-dev ML, Your activity

Yegappan Lakshmanan

unread,
Aug 6, 2020, 3:48:21 PM8/6/20
to vim/vim, vim-dev ML, Push

@yegappan pushed 1 commit.

  • 3be2ae3 Use the filename for comparision in one more place

—
You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,
Aug 7, 2020, 10:49:42 AM8/7/20
to vim/vim, vim-dev ML, Comment

Closed #6638 via 9470a4d.

—
You are receiving this because you commented.

Reply all
Reply to author
Forward
0 new messages