[vim/vim] client-server test fails without X11 server (PR #20709)
MURAOKA Taro
Problem: When unable to connect to X11, serverlist({'list':1}) returns a string instead of a list. This causes Test_remote_serverlist() in test_vim9_builtin.vim to fail.
Solution: Assign a new list even when unable to connect to X11.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20709
Commit Summary
- c3310b9 client-server test fails without X11 server
File Changes
(1 file)
- M src/clientserver.c (2)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
MURAOKA Taro
koron left a comment (vim/vim#20709)Or perhaps We should explicitly raise an error when unable to connect to X11?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Foxe Chen
64-bitman left a comment (vim/vim#20709)Or perhaps We should explicitly raise an error when unable to connect to X11?
I think we should raise an error, I'm pretty sure thats what the other remote_* functions do
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
MURAOKA Taro
koron left a comment (vim/vim#20709)I think we should raise an error, I'm pretty sure thats what the other
remote_*functions do
I see. I'll update it later.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.