Commit: patch 9.1.1478: Unused assignment in ex_uniq()

0 views
Skip to first unread message

Christian Brabandt

unread,
Jun 24, 2025, 2:30:20 PM6/24/25
to vim...@googlegroups.com
patch 9.1.1478: Unused assignment in ex_uniq()

Commit: https://github.com/vim/vim/commit/fc378a88d808ec1d44dd8582498c1b1b6af8e8d6
Author: zeertzjq <zeer...@outlook.com>
Date: Tue Jun 24 19:58:36 2025 +0200

patch 9.1.1478: Unused assignment in ex_uniq()

Problem: Unused assignment in ex_uniq() (after v9.1.1476)
Solution: Remove the assignment and the wrong comments above
(zeertzjq).

closes: #17596

Signed-off-by: zeertzjq <zeer...@outlook.com>
Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/src/ex_cmds.c b/src/ex_cmds.c
index cd2c3046f..c4a86c90e 100644
--- a/src/ex_cmds.c
+++ b/src/ex_cmds.c
@@ -729,15 +729,9 @@ ex_uniq(exarg_T *eap)
}
}

- // Make an array with all line numbers. This avoids having to copy all
- // the lines into allocated memory.
- // When remove deplicating on strings "start_col_nr" is the offset in the
- // line, for numbers remove deplicating it's the number to uniq on. This
- // means the pattern matching only has to be done once per line.
- // Also get the longest line length for allocating "sortbuf".
+ // Find the length of the longest line.
for (lnum = eap->line1; lnum <= eap->line2; ++lnum)
{
- s = ml_get(lnum);
len = ml_get_len(lnum);
if (maxlen < len)
maxlen = len;
diff --git a/src/version.c b/src/version.c
index df89e19d6..6db18c618 100644
--- a/src/version.c
+++ b/src/version.c
@@ -709,6 +709,10 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
+/**/
+ 1478,
+/**/
+ 1477,
/**/
1476,
/**/
Reply all
Reply to author
Forward
0 new messages