[vim/vim] Avoid unnecessary memory allocation in set_callback() (PR #19831)

[Shane Harper]

Problem: set_callback() could duplicate the callback name when the original string could still be used.
Solution: Don't duplicate the callback name when the original string is already owned by the callback.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/19831

Commit Summary

• 23dfcbe Avoid unnecessary memory allocation in set_callback().
• 59333f2 Improve readability of set_callback(); add does_callback_own_cb_name().
• 962ad0d set_callback(): Zero *src after copying to *dest to prevent potential double-free

File Changes

(9 files)

• M src/change.c (2)
• M src/clipboard.c (2)
• M src/evalvars.c (19)
• M src/job.c (4)
• M src/option.c (2)
• M src/popupwin.c (7)
• M src/quickfix.c (4)
• M src/sound.c (2)
• M src/time.c (2)

Patch Links:

• https://github.com/vim/vim/pull/19831.patch
• https://github.com/vim/vim/pull/19831.diff

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19831@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#19831)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19831/c4138094913@github.com>

[Christian Brabandt]

Closed #19831 via 02abcf3.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/19831/issue_event/23949545644@github.com>