[vim/vim] let 'previewpopup' like 'completepopup' (PR #18873)

arkissa

unread,

Dec 6, 2025, 1:55:55 AM12/6/25

to vim/vim, Subscribed

I’ve seen many separate checks in the code specifically for the preview popup window, blocking certain parameters. I’m not familiar with Vim’s codebase, and I don’t really understand why this is done. My understanding is that a preview popup window is just a normal popup window (please correct me if I’m wrong), I also don’t really get why those checks are needed. This PR is meant to address the issue in #18826 and allow previewpopup to have richer configuration, so I removed some of the checks that tested whether a popup was a preview. I’m not sure what side effects this might cause.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/18873

Commit Summary

e87e88a feat: Add more settings to 'previewpopup' like 'completepopup'
3aa549e update: changed 'previewpopup' test cases.
f97487c runtime(doc): 'previewpopup' referenced from 'completepopup'.

File Changes

(4 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

arkissa

unread,

Dec 6, 2025, 1:58:35 AM12/6/25

to vim/vim, Subscribed

Arkissa left a comment (vim/vim#18873)

@girishji @chrisbra Please review this PR

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Dec 9, 2025, 7:18:54 AM12/9/25

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#18873)

this needs a bit of updates to the documentation, I guess we need to also link from 'previewpopup' (this should also document what values can actually be set) to 'pumborder'?. Also, can you please update the tests for all possible option values that this allows then?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

arkissa

unread,

9:08 AM (3 hours ago) 9:08 AM

to vim/vim, Push

@Arkissa pushed 3 commits.

af1d3ad feat: Add more settings to 'previewpopup' like 'completepopup'
75fb8e0 update: changed 'previewpopup' test cases.
b7e968e runtime(doc): 'previewpopup' referenced from 'completepopup'.

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

arkissa

unread,

10:31 AM (1 hour ago) 10:31 AM

to vim/vim, Push

@Arkissa pushed 2 commits.

dc63584 update: delete align options value.
17d111e runtime(doc): Update 'previewpopup' option values information.

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

arkissa

unread,

10:50 AM (1 hour ago) 10:50 AM

to vim/vim, Push

@Arkissa pushed 2 commits.

00c46ff runtime(doc): Update 'previewpopup' option values information.
af93d70 update: previewpopup first value.

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward