[vim/vim] let 'previewpopup' like 'completepopup' (PR #18873)

5 views

Skip to first unread message

arkissa

unread,

Dec 6, 2025, 1:55:55 AM (yesterday) Dec 6

to vim/vim, Subscribed

I’ve seen many separate checks in the code specifically for the preview popup window, blocking certain parameters. I’m not familiar with Vim’s codebase, and I don’t really understand why this is done. My understanding is that a preview popup window is just a normal popup window (please correct me if I’m wrong), I also don’t really get why those checks are needed. This PR is meant to address the issue in #18826 and allow previewpopup to have richer configuration, so I removed some of the checks that tested whether a popup was a preview. I’m not sure what side effects this might cause.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/18873

Commit Summary

e87e88a feat: Add more settings to 'previewpopup' like 'completepopup'
3aa549e update: changed 'previewpopup' test cases.
f97487c runtime(doc): 'previewpopup' referenced from 'completepopup'.

File Changes

(4 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

arkissa

unread,

Dec 6, 2025, 1:58:35 AM (yesterday) Dec 6

to vim/vim, Subscribed

Arkissa left a comment (vim/vim#18873)