[vim/vim] :copen opens multiple quick fix windows (#4548)

[Ben Jackson]

Describe the bug

Running :copen should, according to the docs make the current quick fix window current. As of some recent patch, it is opening a new one.

To Reproduce
Detailed steps to reproduce the behavior:

1. Run vim --clean
2. Type :copen<CR>
3. Type :copen<CR>

Expected behavior
The existing quick fix menu is made current.

Actual behaviour
A second quick fix window is displayed.

Environment (please complete the following information):

(vim-env) BenMBP:vim ben$ ./src/vim --version
VIM - Vi IMproved 8.1 (2018 May 18, compiled Jun 15 2019 20:37:24)
macOS version
Included patches: 1-1547
Compiled by b...@BenMBP.local
Huge version without GUI.  Features included (+) or not (-):
+acl               -farsi             -mouse_sysmouse    -tag_any_white
+arabic            +file_in_path      +mouse_urxvt       +tcl
+autocmd           +find_in_path      +mouse_xterm       +termguicolors
+autochdir         +float             +multi_byte        +terminal
-autoservername    +folding           +multi_lang        +terminfo
-balloon_eval      -footer            -mzscheme          +termresponse
+balloon_eval_term +fork()            +netbeans_intg     +textobjects
-browse            -gettext           +num64             +textprop
++builtin_terms    -hangul_input      +packages          +timers
+byte_offset       +iconv             +path_extra        +title
+channel           +insert_expand     -perl              -toolbar
+cindent           +job               +persistent_undo   +user_commands
-clientserver      +jumplist          +postscript        +vartabs
+clipboard         +keymap            +printer           +vertsplit
+cmdline_compl     +lambda            +profile           +virtualedit
+cmdline_hist      +langmap           -python            +visual
+cmdline_info      +libcall           +python3           +visualextra
+comments          +linebreak         +quickfix          +viminfo
+conceal           +lispindent        +reltime           +vreplace
+cryptv            +listcmds          +rightleft         +wildignore
+cscope            +localmap          +ruby/dyn          +wildmenu
+cursorbind        -lua               +scrollbind        +windows
+cursorshape       +menu              +signs             +writebackup
+dialog_con        +mksession         +smartindent       -X11
+diff              +modify_fname      -sound             -xfontset
+digraphs          +mouse             +spell             -xim
-dnd               -mouseshape        +startuptime       -xpm
-ebcdic            +mouse_dec         +statusline        -xsmp
+emacs_tags        -mouse_gpm         -sun_workshop      -xterm_clipboard
+eval              -mouse_jsbterm     +syntax            -xterm_save
+ex_extra          +mouse_netterm     +tag_binary
+extra_search      +mouse_sgr         -tag_old_static
   system vimrc file: "$VIM/vimrc"
     user vimrc file: "$HOME/.vimrc"
 2nd user vimrc file: "~/.vim/vimrc"
      user exrc file: "$HOME/.exrc"
       defaults file: "$VIMRUNTIME/defaults.vim"
  fall-back for $VIM: "/Users/ben/Development/vim/../vim-env/share/vim"
Compilation: gcc -c -I. -Iproto -DHAVE_CONFIG_H   -DMACOS_X -DMACOS_X_DARWIN  -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1
Linking: gcc   -L.  -L/usr/local/lib -o vim        -lm -lncurses  -liconv -framework AppKit     -L/usr/local/opt/python/Frameworks/Python.framework/Versions/3.7/lib/python3.7/config-3.7m-darwin -lpython3.7m -framework CoreFoundation -F/System/Library/Frameworks -framework Tcl -framework CoreFoundation

macOS

Additional context
I am also finding that jumping to quick fix entries isn't working, so something really bad seems to have happened to quick fix. Was there a recent change in this area?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub

[Yegappan Lakshmanan]

Hi,

On Sat, Jun 15, 2019 at 2:29 PM Ben Jackson <vim-dev...@256bit.org> wrote:
>
> Describe the bug
>
> Running :copen should, according to the docs make the current quick fix window current. As of some recent patch, it is opening a new one.
>
> To Reproduce
> Detailed steps to reproduce the behavior:
>
> Run vim --clean
> Type :copen<CR>
> Type :copen<CR>
>
> Expected behavior
> The existing quick fix menu is made current.
>
> Actual behaviour
> A second quick fix window is displayed.
>

> Additional context
>
> I am also finding that jumping to quick fix entries isn't working, so something really
> bad seems to have happened to quick fix. Was there a recent change in this area?
>

Can you try after patch #1549? The patch #1547 made some changes to
a function that checks whether 'buftype' is nofile or not. It looks like this
broke the quickfix functionality.

- Yegappan

[vim-dev ML]

Hi,

On Sat, Jun 15, 2019 at 2:29 PM Ben Jackson <vim-dev...@256bit.org> wrote:
>

> Describe the bug
>
> Running :copen should, according to the docs make the current quick fix window current. As of some recent patch, it is opening a new one.
>
> To Reproduce
> Detailed steps to reproduce the behavior:
>
> Run vim --clean
> Type :copen<CR>
> Type :copen<CR>
>
> Expected behavior
> The existing quick fix menu is made current.
>
> Actual behaviour
> A second quick fix window is displayed.
>

> Additional context
>
> I am also finding that jumping to quick fix entries isn't working, so something really
> bad seems to have happened to quick fix. Was there a recent change in this area?
>

Can you try after patch #1549? The patch #1547 made some changes to
a function that checks whether 'buftype' is nofile or not. It looks like this
broke the quickfix functionality.

- Yegappan

[Ben Jackson]

👍 yep that was it. thanks.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[Ben Jackson]

Closed #4548.

—
You are receiving this because you commented.