[vim/vim] Apply pumopt opacity to wildmenu pum (PR #20072)

[mattn]

Call pum_call_update_screen() in cmdline_pum_display() so that the opacity setting in 'pumopt' takes effect for the popup menu shown when 'wildoptions' contains "pum". Other 'pumopt' suboptions (height/width/border/shadow/margin) already apply via the shared pum_display() path; only opacity required this extra hook.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/20072

Commit Summary

• e367438 Apply pumopt opacity to wildmenu pum

File Changes

(1 file)

• M src/cmdexpand.c (2)

Patch Links:

• https://github.com/vim/vim/pull/20072.patch
• https://github.com/vim/vim/pull/20072.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20072@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#20072)

Hm, does this change break this test:

Failures: 
	From test_cmdline.vim:
	Found errors in Test_long_line_noselect():
	Run 1, 20:38:17 - 20:38:22 in  5.021541 seconds:
	Caught exception in Test_long_line_noselect(): WaitFor() timed out after 5000 msec @ command line..script /tmp/cirrus-ci-build/src/testdir/runtest.vim[636]..function RunTheTest[63]..Test_long_line_noselect[23]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
	Run 2, 20:38:24 - 20:38:29 in  5.053038 seconds:
	Caught exception in Test_long_line_noselect(): WaitFor() timed out after 5000 msec @ command line..script /tmp/cirrus-ci-build/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_long_line_noselect[23]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
	Run 3, 20:38:33 - 20:38:38 in  5.113310 seconds:
	Caught exception in Test_long_line_noselect(): WaitFor() timed out after 5000 msec @ command line..script /tmp/cirrus-ci-build/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_long_line_noselect[23]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
	Run 4, 20:38:44 - 20:38:49 in  5.113314 seconds:
	Caught exception in Test_long_line_noselect(): WaitFor() timed out after 5000 msec @ command line..script /tmp/cirrus-ci-build/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_long_line_noselect[23]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
	Run 5, 20:38:57 - 20:39:02 in  5.112524 seconds:
	Caught exception in Test_long_line_noselect(): WaitFor() timed out after 5000 msec @ command line..script /tmp/cirrus-ci-build/src/testdir/runtest.vim[677]..function RunTheTest[63]..Test_long_line_noselect[23]..WaitForTermCurPosAndLinesToMatch[6]..WaitFor, line 4
	Flaky test failed too often, giving up

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20072/c4321585996@github.com>

[Christian Brabandt]

chrisbra left a comment (vim/vim#20072)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20072/c4329400899@github.com>

[Christian Brabandt]

Closed #20072 via 7070a85.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/20072/issue_event/24917889856@github.com>