[vim/vim] add :iput ex command (PR #16886)

64-bitman

unread,

Mar 13, 2025, 9:55:30 PMMar 13

to vim/vim, Subscribed

Fixes #16225

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/16886

Commit Summary

f88b26a add :iput ex command

File Changes

(6 files)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 13, 2025, 10:06:09 PMMar 13

to vim/vim, Push

@64-bitman pushed 1 commit.

822f6b4 add test

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 13, 2025, 11:10:55 PMMar 13

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In runtime/doc/change.txt:

> @@ -1149,6 +1149,11 @@ inside of strings can change!  Also see 'softtabstop' option. >
 :[line]pu[t]! [x]	Put the text [from register x] before [line] (default
 			current line).
 
+							*:ipu* *:iput*
+:[line]ipu[t] [x]	like |:put|, but adjust indent to the current line

⬇️ Suggested change

-:[line]ipu[t] [x]	like |:put|, but adjust indent to the current line
+:[line]ip[ut] [x]	like |:put|, but adjust indent to the current line

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 13, 2025, 11:11:05 PMMar 13

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In runtime/doc/change.txt:

> @@ -1149,6 +1149,11 @@ inside of strings can change!  Also see 'softtabstop' option. >
 :[line]pu[t]! [x]	Put the text [from register x] before [line] (default
 			current line).
 
+							*:ipu* *:iput*
+:[line]ipu[t] [x]	like |:put|, but adjust indent to the current line
+
+:[line]ipu[t]! [x]	like |:put!|, but adjust indent to the current line

⬇️ Suggested change

-:[line]ipu[t]! [x]	like |:put!|, but adjust indent to the current line
+:[line]ip[ut]! [x]	like |:put!|, but adjust indent to the current line

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 13, 2025, 11:11:19 PMMar 13

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In runtime/doc/index.txt:

> @@ -1559,6 +1559,8 @@ tag		command		action ~
 |:ptselect|	:pts[elect]	|:tselect| and show tag in preview window
 |:public|	:public		prefix for a class or object member
 |:put|		:pu[t]		insert contents of register in the text
+|:iput|		:ipu[t]		like |:put|, but adjust the indent to the

⬇️ Suggested change

-|:iput|		:ipu[t]		like |:put|, but adjust the indent to the 
+|:iput|		:ip[ut]		like |:put|, but adjust the indent to the

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 13, 2025, 11:11:24 PMMar 13

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In runtime/doc/change.txt:

> @@ -1149,6 +1149,11 @@ inside of strings can change!  Also see 'softtabstop' option. >
 :[line]pu[t]! [x]	Put the text [from register x] before [line] (default
 			current line).
 
+							*:ipu* *:iput*

⬇️ Suggested change

-							*:ipu* *:iput*
+							*:ip* *:iput*

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 13, 2025, 11:11:51 PMMar 13

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In src/ex_cmds.h:

> +EXCMD(CMD_iput,		"iput",		ex_iput,
+	EX_RANGE|EX_WHOLEFOLD|EX_BANG|EX_REGSTR|EX_TRLBAR|EX_ZEROR|EX_CMDWIN|EX_LOCK_OK|EX_MODIFY,
+	ADDR_LINES),

This should appear near other Ex commands that start with 'i'.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Mar 14, 2025, 1:34:17 AMMar 14

to vim/vim, Subscribed

@yegappan commented on this pull request.

In src/testdir/test_put.vim:

> @@ -75,6 +75,8 @@ func Test_put_fails_when_nomodifiable()
   normal! yy
   call assert_fails(':put', 'E21:')
   call assert_fails(':put!', 'E21:')
+  call assert_fails(':iput', 'E21:')
+  call assert_fails(':iput!', 'E21:')
   call assert_fails(':normal! p', 'E21:')

The new command needs a lot more tests.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 14, 2025, 1:37:25 AMMar 14

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In runtime/doc/index.txt:

> @@ -1559,6 +1559,8 @@ tag		command		action ~
 |:ptselect|	:pts[elect]	|:tselect| and show tag in preview window
 |:public|	:public		prefix for a class or object member
 |:put|		:pu[t]		insert contents of register in the text
+|:iput|		:ipu[t]		like |:put|, but adjust the indent to the

This one should also be moved between :interface and :isearch

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 1:51:42 AMMar 14

to vim/vim, Push

@64-bitman pushed 2 commits.

6399bf0 fix doc formatting
64369a0 change order of ex_cmds def

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 1:53:22 AMMar 14

to vim/vim, Subscribed

@64-bitman commented on this pull request.

In src/testdir/test_put.vim:

> @@ -75,6 +75,8 @@ func Test_put_fails_when_nomodifiable()
   normal! yy
   call assert_fails(':put', 'E21:')
   call assert_fails(':put!', 'E21:')
+  call assert_fails(':iput', 'E21:')
+  call assert_fails(':iput!', 'E21:')
   call assert_fails(':normal! p', 'E21:')

The new command needs a lot more tests.

Could you describe some?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 3:56:11 AMMar 14

to vim/vim, Push

@64-bitman pushed 1 commit.

0fd8cda update ex_cmdidxs.h

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Mar 14, 2025, 10:08:47 AMMar 14

to vim/vim, Subscribed

@yegappan commented on this pull request.

In src/testdir/test_put.vim:

> @@ -75,6 +75,8 @@ func Test_put_fails_when_nomodifiable()
   normal! yy
   call assert_fails(':put', 'E21:')
   call assert_fails(':put!', 'E21:')
+  call assert_fails(':iput', 'E21:')
+  call assert_fails(':iput!', 'E21:')
   call assert_fails(':normal! p', 'E21:')

The following is a list of possible tests:

Yank some lines (with a different indentation) and paste it after an indented line and make sure the pasted lines are indented.
Try pasting before the first line and after the first line.
Try pasting a line with no indentation and check the indentation of the pasted lines.
Specify invalid range to the ":iput" command.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Mar 14, 2025, 10:09:20 AMMar 14

to vim/vim, Subscribed

@yegappan commented on this pull request.

In src/testdir/test_put.vim:

> @@ -75,6 +75,8 @@ func Test_put_fails_when_nomodifiable()
   normal! yy
   call assert_fails(':put', 'E21:')
   call assert_fails(':put!', 'E21:')
+  call assert_fails(':iput', 'E21:')
+  call assert_fails(':iput!', 'E21:')
   call assert_fails(':normal! p', 'E21:')

As you have added code to compile the iput command, you need to a Vim9 script test where a def function calls the iput command.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 2:33:44 PMMar 14

to vim/vim, Push

@64-bitman pushed 1 commit.

ca3940e fix vim9 instruction

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 2:34:08 PMMar 14

to vim/vim, Push

@64-bitman pushed 1 commit.

fda5003 fix vim9 instruction

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 2:49:54 PMMar 14

to vim/vim, Push

@64-bitman pushed 1 commit.

efc9236 fix vim9 instruction

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 3:16:23 PMMar 14

to vim/vim, Push

@64-bitman pushed 1 commit.

3d339b8 fix vim9 instruction

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 3:19:17 PMMar 14

to vim/vim, Push

@64-bitman pushed 1 commit.

8b3e3cc change comments

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 3:35:58 PMMar 14

to vim/vim, Push

@64-bitman pushed 1 commit.

fa37bb8 add more tests

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 14, 2025, 3:37:42 PMMar 14

to vim/vim, Subscribed

64-bitman left a comment (vim/vim#16886)

I think everything is ready

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Mar 16, 2025, 4:20:56 PMMar 16

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#16886)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Mar 16, 2025, 4:21:02 PMMar 16

to vim/vim, Subscribed

Closed #16886 via 250739d.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Mar 16, 2025, 4:39:52 PMMar 16

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#16886)

There are a few errors here, which I unfortunately did not notice. So I'll revert this for now. Can you please check CI logs?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Mar 16, 2025, 4:42:36 PMMar 16

to vim/vim, Subscribed

Reopened #16886.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Peter Aronoff

unread,

Mar 16, 2025, 4:58:21 PMMar 16

to vim/vim, Subscribed

telemachus left a comment (vim/vim#16886)

Thank you!

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 6:54:17 PMMar 16

to vim/vim, Subscribed

64-bitman left a comment (vim/vim#16886)

There are a few errors here, which I unfortunately did not notice. So I'll revert this for now. Can you please check CI logs?

Sure.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 7:00:28 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

369ce1e add ISN_IPUT instruction to delete_instr()

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 7:12:33 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

f7fdc56 initialize variable

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 7:18:49 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

fd09974 fix formatting

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 7:23:42 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

76cc8da fix formatting

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 7:45:17 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

2167bed add doc tags

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 7:50:56 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

af7bb17 fix tags

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Mar 16, 2025, 7:54:41 PMMar 16

to vim/vim, Subscribed

@yegappan commented on this pull request.

In src/vim9.h:

> @@ -200,6 +200,7 @@ typedef enum {
     ISN_USEDICT,    // use or clear dict saved by ISN_MEMBER/ISN_STRINGMEMBER
 
     ISN_PUT,	    // ":put", uses isn_arg.put
+    ISN_IPUT,	    // ":iput", uses isn_arg.put

Can you add a new test to the test_vim9_disassemble.vim file for this new instruction?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Mar 16, 2025, 7:59:20 PMMar 16

to vim/vim, Subscribed

@yegappan requested changes on this pull request.

In src/testdir/test_put.vim:

> @@ -328,4 +330,63 @@ func Test_put_list()
   bw!
 endfunc
 
+func Test_iput_multiline()
+  new
+  setlocal noexpandtab
+  call feedkeys("i\<Tab>foo", 'x')

You can use setline() or append() instead of feedkeys() here.

In src/testdir/test_put.vim:

> +  call feedkeys("i\<Tab>foo", 'x')
+  call setreg('0', "bar\n\<Tab>bar2\nbar3", 'l')
+  exe "iput"
+  call assert_equal(["\<Tab>bar", "\<Tab>\<Tab>bar2", "\<Tab>bar3"], getline(2, 4))
+  setlocal expandtab tabstop=8 shiftwidth=8 noshiftround
+  exe "iput"
+  call assert_equal([repeat(' ', 8) . "bar",
+        \ repeat(' ', 16) . "bar2",
+        \ repeat(' ', 8) . "bar3"], getline(5, 7))
+  bw!
+endfunc
+
+func Test_iput_beforeafter_tab()
+  new
+  setlocal noexpandtab
+  call feedkeys("i\<Tab>foo", 'x')

You can use setline() or append() here.

In src/testdir/test_put.vim:

> @@ -328,4 +330,63 @@ func Test_put_list()
   bw!
 endfunc
 
+func Test_iput_multiline()
+  new
+  setlocal noexpandtab
+  call feedkeys("i\<Tab>foo", 'x')
+  call setreg('0', "bar\n\<Tab>bar2\nbar3", 'l')
+  exe "iput"

No need to use "exe" here. You can use the command "iput" by itself.

In src/testdir/test_put.vim:

> +endfunc
+
+func Test_iput_invalidrange()
+  new
+  call setreg('0', "bar", 'l')
+  call assert_fails(':10iput', 'E16:')
+  bw!
+endfunc
+
+func Test_iput_not_put()
+  new
+  call feedkeys("i\<Tab>foo", 'x')
+  call setreg('0', "bar", 'l')
+  exe "iput"
+  call assert_equal("\<Tab>bar", getline(2))
+  exe "put"

You can remove "exe" from all of these tests for "iput" and "put".

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 8:09:20 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

7a765fd refactor tests

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 8:13:17 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

02946c6 modify tests

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

Yegappan Lakshmanan

unread,

Mar 16, 2025, 8:15:32 PMMar 16

to vim/vim, Subscribed

@yegappan requested changes on this pull request.

In src/testdir/test_put.vim:

> @@ -328,4 +330,63 @@ func Test_put_list()
   bw!
 endfunc
 
+func Test_iput_multiline()
+  new
+  setlocal noexpandtab
+  call setline(1, "\<Tab>foo")
+  call setreg('0', "bar\n\<Tab>bar2\nbar3", 'l')
+  iput
+  call assert_equal(["\<Tab>bar", "\<Tab>\<Tab>bar2", "\<Tab>bar3"], getline(2, 4))
+  setlocal expandtab tabstop=8 shiftwidth=8 noshiftround
+  exe "iput"

Can you remove "exe" from here?

In src/testdir/test_put.vim:

> +  iput
+  call assert_equal(["\<Tab>bar", "\<Tab>\<Tab>bar2", "\<Tab>bar3"], getline(2, 4))
+  setlocal expandtab tabstop=8 shiftwidth=8 noshiftround
+  exe "iput"
+  call assert_equal([repeat(' ', 8) . "bar",
+        \ repeat(' ', 16) . "bar2",
+        \ repeat(' ', 8) . "bar3"], getline(5, 7))
+  bw!
+endfunc
+
+func Test_iput_beforeafter_tab()
+  new
+  setlocal noexpandtab
+  call setline(1, "\<Tab>foo")
+  call setreg('0', "bar", 'l')
+  exe "iput"

Can you remove "exe" from here?

In src/testdir/test_put.vim:

> +  exe "iput"
+  call assert_equal([repeat(' ', 8) . "bar",
+        \ repeat(' ', 16) . "bar2",
+        \ repeat(' ', 8) . "bar3"], getline(5, 7))
+  bw!
+endfunc
+
+func Test_iput_beforeafter_tab()
+  new
+  setlocal noexpandtab
+  call setline(1, "\<Tab>foo")
+  call setreg('0', "bar", 'l')
+  exe "iput"
+  call assert_equal(["\<Tab>bar"], getline(2, '$'))
+  call feedkeys("k", 'x')
+  exe "iput!"

Can you remove "exe" from here?

In src/testdir/test_put.vim:

> +  call setreg('0', "bar", 'l')
+  exe "iput"
+  call assert_equal(["\<Tab>bar"], getline(2, '$'))
+  call feedkeys("k", 'x')
+  exe "iput!"
+  call assert_equal("\<Tab>bar", getline(1))
+  call assert_equal("\<Tab>bar", getline(3))
+  bw!
+endfunc
+
+func Test_iput_beforeafter_expandtab()
+  new
+  setlocal expandtab tabstop=8 shiftwidth=8 noshiftround
+  call feedkeys("i\<Tab>foo", 'x')
+  call setreg('0', "bar", 'l')
+  exe "iput"

Can you remove "exe" from here?

In src/testdir/test_put.vim:

> +  call assert_equal(["\<Tab>bar"], getline(2, '$'))
+  call feedkeys("k", 'x')
+  exe "iput!"
+  call assert_equal("\<Tab>bar", getline(1))
+  call assert_equal("\<Tab>bar", getline(3))
+  bw!
+endfunc
+
+func Test_iput_beforeafter_expandtab()
+  new
+  setlocal expandtab tabstop=8 shiftwidth=8 noshiftround
+  call feedkeys("i\<Tab>foo", 'x')
+  call setreg('0', "bar", 'l')
+  exe "iput"
+  call assert_equal([repeat(' ', 8) . "bar"], getline(2, '$'))
+  exe "1iput!"

Can you remove "exe" from here?

In src/vim9execute.c:

> @@ -7619,7 +7635,18 @@ list_instructions(char *pfx, isn_T *instr, int instr_count, ufunc_T *ufunc)
 						 iptr->isn_arg.put.put_regname,
 					     (long)iptr->isn_arg.put.put_lnum);
 		break;
-
+	    case ISN_IPUT:
+		if (iptr->isn_arg.put.put_lnum == LNUM_VARIABLE_RANGE_ABOVE)
+		    smsg("%s%4d PUT %c above range",

To differentiate this instruction from "ISN_PUT", can you use "IPUT" instead "PUT" here?

In src/vim9execute.c:

> @@ -7619,7 +7635,18 @@ list_instructions(char *pfx, isn_T *instr, int instr_count, ufunc_T *ufunc)
 						 iptr->isn_arg.put.put_regname,
 					     (long)iptr->isn_arg.put.put_lnum);
 		break;
-
+	    case ISN_IPUT:
+		if (iptr->isn_arg.put.put_lnum == LNUM_VARIABLE_RANGE_ABOVE)
+		    smsg("%s%4d PUT %c above range",
+				  pfx, current, iptr->isn_arg.put.put_regname);
+		else if (iptr->isn_arg.put.put_lnum == LNUM_VARIABLE_RANGE)
+		    smsg("%s%4d PUT %c range",

To differentiate this instruction from "ISN_PUT", can you use "IPUT" instead "PUT" here?

In src/vim9execute.c:

> @@ -7619,7 +7635,18 @@ list_instructions(char *pfx, isn_T *instr, int instr_count, ufunc_T *ufunc)
 						 iptr->isn_arg.put.put_regname,
 					     (long)iptr->isn_arg.put.put_lnum);
 		break;
-
+	    case ISN_IPUT:
+		if (iptr->isn_arg.put.put_lnum == LNUM_VARIABLE_RANGE_ABOVE)
+		    smsg("%s%4d PUT %c above range",
+				  pfx, current, iptr->isn_arg.put.put_regname);
+		else if (iptr->isn_arg.put.put_lnum == LNUM_VARIABLE_RANGE)
+		    smsg("%s%4d PUT %c range",
+				  pfx, current, iptr->isn_arg.put.put_regname);
+		else
+		    smsg("%s%4d PUT %c %ld", pfx, current,

To differentiate this instruction from "ISN_PUT", can you use "IPUT" instead "PUT" here?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 8:17:51 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

978479a fix tests

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 8:19:17 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

5f53802 fix error messages

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 8:30:24 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

3223906 fix test

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 16, 2025, 8:55:53 PMMar 16

to vim/vim, Push

@64-bitman pushed 1 commit.

5170b10 add test

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

h_east

unread,

Mar 17, 2025, 10:34:24 AMMar 17

to vim/vim, Subscribed

@h-east commented on this pull request.

In src/ex_docmd.c:

> +	if (valid_yank_reg(*ea.arg, ((ea.cmdidx != CMD_put && ea.cmdidx != CMD_iput)
 					      && !IS_USER_CMDIDX(ea.cmdidx))))

Fixed over 80 columns.
There is an extra parentheses.
(Although I changed the order) I think this is better.

⬇️ Suggested change

-	if (valid_yank_reg(*ea.arg, ((ea.cmdidx != CMD_put && ea.cmdidx != CMD_iput)
-					      && !IS_USER_CMDIDX(ea.cmdidx))))
+	if (valid_yank_reg(*ea.arg, (!IS_USER_CMDIDX(ea.cmdidx)
+			    && ea.cmdidx != CMD_put && ea.cmdidx != CMD_iput)))

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 17, 2025, 6:15:55 PMMar 17

to vim/vim, Push

@64-bitman pushed 1 commit.

5b0f09b refactor

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 17, 2025, 7:23:01 PMMar 17

to vim/vim, Push

@64-bitman pushed 1 commit.

d38ce33 Merge branch 'master' into 16225

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 17, 2025, 7:39:31 PMMar 17

to vim/vim, Push

@64-bitman pushed 1 commit.

cb08e83 fix syntax errors

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 17, 2025, 8:08:31 PMMar 17

to vim/vim, Push

@zeertzjq pushed 1 commit.

2637dfb fix wrong test changes

—
View it on GitHub or unsubscribe.

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 17, 2025, 8:10:01 PMMar 17

to vim/vim, Subscribed

zeertzjq left a comment (vim/vim#16886)

There are some incorrect test changes after the merge from master branch. I pushed a commit to fix them.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

Mar 17, 2025, 8:10:13 PMMar 17

to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In src/vim9execute.c:

> @@ -3252,6 +3252,58 @@ var_any_get_oc_member(class_T *current_class, isn_T *iptr, typval_T *tv)
     return OK;
 }
 
+/*
+ * do ISN_PUT or ISN_IPUT instruction depending on fixindent parameter
+ */
+    static void
+isn_put_do (ectx_T *ectx, isn_T *iptr, typval_T *tv, int fixindent)

⬇️ Suggested change

-isn_put_do (ectx_T *ectx, isn_T *iptr, typval_T *tv, int fixindent)
+isn_put_do(ectx_T *ectx, isn_T *iptr, typval_T *tv, int fixindent)

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 17, 2025, 9:13:47 PMMar 17

to vim/vim, Push

@64-bitman pushed 1 commit.

7c1ae80 fix formatting

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

64-bitman

unread,

Mar 18, 2025, 5:24:01 PMMar 18

to vim/vim, Subscribed

64-bitman left a comment (vim/vim#16886)

I think this is ready

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Mar 18, 2025, 5:32:12 PMMar 18

to vim/vim, Subscribed

Closed #16886 via e08f10a.

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

Mar 18, 2025, 5:33:03 PMMar 18

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#16886)

Thanks. It was a bit complicated to get all changes merged into a single commit, but I think I made it :)
I also added another test for :0iput. Thanks all.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Peter Aronoff

unread,

Mar 18, 2025, 7:29:45 PMMar 18

to vim/vim, Subscribed

telemachus left a comment (vim/vim#16886)