[vim/vim] expand all tabs in sound.c (PR #15969)

12 views
Skip to first unread message

Luca Saccarola

unread,
Oct 31, 2024, 10:42:30 AM10/31/24
to vim/vim, Subscribed

This PR tries to make more manageable to review #13318 (comment) by simply expand the tabs into spaces and modifying the modeline

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/15969

Commit Summary

  • d9af8ec expand all tabs in sound.c

File Changes

(1 file)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969@github.com>

zeertzjq

unread,
Oct 31, 2024, 8:08:10 PM10/31/24
to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In src/sound.c:

> @@ -1,6 +1,6 @@
-/* vi:set ts=8 sts=4 sw=4 noet:
+/* vi:set ts=4 sts=4 sw=4 et:

Why change 'ts' when 'sts' is already set?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969/review/2409277080@github.com>

Luca Saccarola

unread,
Oct 31, 2024, 11:07:03 PM10/31/24
to vim/vim, Subscribed

@saccarosium commented on this pull request.

In src/sound.c:

> @@ -1,6 +1,6 @@
-/* vi:set ts=8 sts=4 sw=4 noet:
+/* vi:set ts=4 sts=4 sw=4 et:

For retab and for clarity. I think make more sense to have all 4.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969/review/2409397375@github.com>

zeertzjq

unread,
Oct 31, 2024, 11:17:20 PM10/31/24
to vim/vim, Subscribed

@zeertzjq commented on this pull request.

In src/sound.c:

> @@ -1,6 +1,6 @@
-/* vi:set ts=8 sts=4 sw=4 noet:
+/* vi:set ts=4 sts=4 sw=4 et:

How? For :retab a Tab should be expanded to 8 spaces, not 4.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969/review/2409404115@github.com>

Luca Saccarola

unread,
Nov 2, 2024, 7:48:49 AM11/2/24
to vim/vim, Push

@saccarosium pushed 1 commit.

  • d986684 expand all tabs in sound.c

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969/before/d9af8ec7cd77392a9bcc1eb5d410c0ba0945b283/after/d98668485a554fda3664493b99db6ed0dbb2995b@github.com>

Luca Saccarola

unread,
Nov 2, 2024, 7:50:19 AM11/2/24
to vim/vim, Subscribed

@saccarosium commented on this pull request.

In src/sound.c:

> @@ -1,6 +1,6 @@
-/* vi:set ts=8 sts=4 sw=4 noet:
+/* vi:set ts=4 sts=4 sw=4 et:

I've changed it

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969/review/2411238589@github.com>

Christian Brabandt

unread,
Nov 2, 2024, 11:33:35 AM11/2/24
to vim/vim, Subscribed

Closed #15969 via 8ce738d.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969/issue_event/15082090609@github.com>

Christian Brabandt

unread,
Nov 2, 2024, 11:44:29 AM11/2/24
to vim/vim, Subscribed

Thanks. I have included it now and also added a new file: https://github.com/vim/vim/blob/master/.git-blame-ignore-revs to ignore this revision for git-blame.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15969/c2453027157@github.com>

Reply all
Reply to author
Forward
0 new messages