[vim/vim] feat: Add support for the Nix programming language. (PR #11646)

John Soo

unread,

Dec 1, 2022, 11:29:58 AM12/1/22

to vim/vim, Subscribed

The Nix language and package manager is now quite a large project (nixpkgs is of the largest and most active projects on GitHub, see https://github.com/NixOS/nixpkgs). It uses a domain-specific language for configuration. This PR adds syntax for the language.

The syntax is pulled from https://github.com/LnL7/vim-nix which is under MIT license. I have included attribution to the original author and a referred back to the GitHub repository. I reached out to the maintainer a few months ago to ask about including their code in vim. I got no response (LnL7/vim-nix#47), so I think it should be ok to proceed including this PR.

Note that I found a maintainer for the syntax file that is not me: @equill (ja...@electronic-quill.net) volunteered as the contact who is listed as maintainer in runtime/syntax/nix.vim.

@equill would you mind acknowledging that your contact information is correct and that you will be the point of contact for the Nix syntax highlighting?

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/11646

Commit Summary

305b907 feat: Add support for the Nix programming language.

File Changes

(1 file)

A runtime/syntax/nix.vim (204)

Patch Links:

—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.

Equill

unread,

Dec 1, 2022, 11:40:24 AM12/1/22

to vim/vim, Subscribed

I confirm of my own free will that I have indeed volunteered to be the maintainer/contact for this.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Dec 2, 2022, 2:02:30 PM12/2/22

to vim/vim, Subscribed

Can you please also add an entry in .github/CODEOWNERS ?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

John Soo

unread,

Dec 2, 2022, 2:44:59 PM12/2/22

to vim/vim, Subscribed

Yes I can, though I'll be out till Monday.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

John Soo

unread,

Dec 5, 2022, 3:05:18 PM12/5/22

to vim/vim, Push

@jsoo1 pushed 1 commit.

571ca75 CODEOWNERS: Mark runtime/syntax/nix.vim owned by @equill.

—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.

John Soo

unread,

Dec 5, 2022, 3:07:00 PM12/5/22

to vim/vim, Subscribed

Ok I've added @equill as owner of runtime/syntax/nix.vim. I think there may be other nix support files that could be pulled from https://github.com/LnL7/vim-nix but I just don't know enough about vim to do the work.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Dec 6, 2022, 4:45:33 AM12/6/22

to vim/vim, Subscribed

Thanks, I'll include it.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Dec 6, 2022, 4:45:34 AM12/6/22

to vim/vim, Subscribed

Closed #11646.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Dec 6, 2022, 4:54:32 AM12/6/22

to vim/vim, Subscribed

Noticed afterwards: The file uses line continuation, it should set the 'cpo' option and restore it.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

John Soo

unread,

Dec 6, 2022, 9:13:47 AM12/6/22

to vim/vim, Subscribed

Noticed afterwards: The file uses line continuation, it should set the 'cpo' option and restore it.

Do you want a separate patch for that? If so, @equill would you mind doing the honors?

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Equill

unread,

Dec 6, 2022, 5:25:41 PM12/6/22

to vim/vim, Subscribed

Noticed afterwards: The file uses line continuation, it should set the 'cpo' option and restore it.

Do you want a separate patch for that? If so, @equill would you mind doing the honors?

Sure, will do. Sorry about the slow response; I'm in transit and very jet-lagged.

—
Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.

Bram Moolenaar

unread,

Dec 7, 2022, 4:01:41 AM12/7/22

to vim/vim, Subscribed

> > Noticed afterwards: The file uses line continuation, it should set
> > the 'cpo' option and restore it.
>
> Do you want a separate patch for that? If so, @equill would you mind
> doing the honors?

I fixed it in my copy, it's the standard lines. I'll make a runtime
files update soon, please sync and make any further changes on top of
that.

--
hundred-and-one symptoms of being an internet addict:
249. You've forgotten what the outside looks like.

/// Bram Moolenaar -- ***@***.*** -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///