[vim/vim] LSP messages are not parsed properly if the http header and json payload are received separately (PR #10215)
32 views
Skip to first unread message
Yegappan Lakshmanan
Apr 17, 2022, 4:04:34 PM4/17/22
to vim/vim, Subscribed
Collapse all the received data before parsing the LSP messages.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/10215
Commit Summary
- 1a868f0 LSP messages are not parsed properly if the http header and json payload are received separately
File Changes
(3 files)
- M src/channel.c (19)
- M src/testdir/test_channel.vim (5)
- M src/testdir/test_channel_lsp.py (16)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Apr 17, 2022, 4:15:56 PM4/17/22
to vim/vim, Subscribed
Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
Apr 17, 2022, 4:21:26 PM4/17/22
to vim_dev, reply+ACY5DGH54SWRQMPHR5...@reply.github.com, vim/vim, Subscribed
Hi Christian,
On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt <vim-dev...@256bit.org> wrote:
Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
Thanks,
Yegappan
vim-dev ML
Apr 17, 2022, 4:21:46 PM4/17/22
to vim/vim, vim-dev ML, Your activity
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Apr 17, 2022, 4:24:45 PM4/17/22
to vim...@googlegroups.com, reply+ACY5DGH54SWRQMPHR5...@reply.github.com, vim/vim, Subscribed
Best,
Christian
--
Ein Mensch in einer fremden Stadt fragt:
"Wissen Sie, wo es zum Bahnhof geht?"
Bioenergetiker: "Machen Sie mal sch... sch... sch... !"
vim-dev ML
Apr 17, 2022, 4:25:03 PM4/17/22
to vim/vim, vim-dev ML, Your activity
On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
> Hi Christian,
>
> On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt ***@***.***> wrote:
>
>
> Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
>
>
>
> Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
Yes of course. Once this is merged, I can enable the test again.
Best,
Christian
--
Ein Mensch in einer fremden Stadt fragt:
"Wissen Sie, wo es zum Bahnhof geht?"
Bioenergetiker: "Machen Sie mal sch... sch... sch... !"
>
>
> Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
>
>
>
> Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
Yes of course. Once this is merged, I can enable the test again.
Best,
Christian
--
Ein Mensch in einer fremden Stadt fragt:
"Wissen Sie, wo es zum Bahnhof geht?"
Bioenergetiker: "Machen Sie mal sch... sch... sch... !"
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Yegappan Lakshmanan
Apr 18, 2022, 12:50:35 AM4/18/22
to vim/vim, vim-dev ML, Push
@yegappan pushed 1 commit.
- 69bfad8 Update doc
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
codecov[bot]
Apr 18, 2022, 1:19:28 AM4/18/22
to vim/vim, vim-dev ML, Comment
Codecov Report
Merging #10215 (5209831) into master (53e8f3f) will increase coverage by
1.38%.
The diff coverage is88.88%.
@@ Coverage Diff @@ ## master #10215 +/- ## ========================================== + Coverage 81.01% 82.40% +1.38% ========================================== Files 161 148 -13 Lines 185331 171582 -13749 Branches 41845 38793 -3052 ========================================== - Hits 150149 141391 -8758 + Misses 22630 17540 -5090 - Partials 12552 12651 +99
| Flag | Coverage Δ | |
|---|---|---|
| huge-clang-none | 82.40% <88.88%> (-0.01%) |
⬇️ |
| linux | 82.40% <88.88%> (-0.01%) |
⬇️ |
| mingw-x64-HUGE-gui | ? |
|
| windows | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/channel.c | 83.14% <88.88%> (-0.49%) |
⬇️ |
| src/highlight.c | 78.57% <0.00%> (-2.72%) |
⬇️ |
| src/time.c | 86.93% <0.00%> (-2.38%) |
⬇️ |
| src/buffer.c | 83.98% <0.00%> (-2.35%) |
⬇️ |
| src/help.c | 79.89% <0.00%> (-2.35%) |
⬇️ |
| src/misc2.c | 86.55% <0.00%> (-2.34%) |
⬇️ |
| src/libvterm/src/screen.c | 51.96% <0.00%> (-2.04%) |
⬇️ |
| src/blob.c | 89.91% <0.00%> (-2.01%) |
⬇️ |
| src/gui.c | 71.18% <0.00%> (-2.01%) |
⬇️ |
| src/session.c | 62.83% <0.00%> (-2.01%) |
⬇️ |
| ... and 135 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 53e8f3f...5209831. Read the comment docs.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
Bram Moolenaar
Apr 18, 2022, 9:08:10 AM4/18/22
to vim/vim, vim-dev ML, Comment
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
Yegappan Lakshmanan
Apr 21, 2022, 11:46:12 AM4/21/22
to vim_dev, reply+ACY5DGH54SWRQMPHR5...@reply.github.com, vim/vim, Subscribed
Hi Christian,
On Sun, Apr 17, 2022 at 1:24 PM Christian Brabandt <cbl...@256bit.org> wrote:
>
>
> On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
>
> > Hi Christian,
> >
> > On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt <vim-dev...@256bit.org> wrote:
> >
> >
> > Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
> >
> >
> >
> > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
>
> Yes of course. Once this is merged, I can enable the test again.
>
It looks like the LSP tests are now passing in the vim-win32-installer
CI but failing somewhere else?
Regards,
Yegappan
On Sun, Apr 17, 2022 at 1:24 PM Christian Brabandt <cbl...@256bit.org> wrote:
>
>
> On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
>
> > Hi Christian,
> >
> > On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt <vim-dev...@256bit.org> wrote:
> >
> >
> > Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
> >
> >
> >
> > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
>
> Yes of course. Once this is merged, I can enable the test again.
>
CI but failing somewhere else?
Regards,
Yegappan
vim-dev ML
Apr 21, 2022, 11:46:28 AM4/21/22
to vim/vim, vim-dev ML, Your activity
Hi Christian,
On Sun, Apr 17, 2022 at 1:24 PM Christian Brabandt ***@***.***> wrote:
>
>
> On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
>
> > Hi Christian,
> >
On Sun, Apr 17, 2022 at 1:24 PM Christian Brabandt ***@***.***> wrote:
>
>
> On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
>
> > Hi Christian,
> >
> > On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt ***@***.***> wrote:
> >
> >
> > Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
> >
> >
> >
> > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
>
> Yes of course. Once this is merged, I can enable the test again.
>
It looks like the LSP tests are now passing in the vim-win32-installer
CI but failing somewhere else?
Regards,
Yegappan
> >
> >
> > Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
> >
> >
> >
> > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
>
> Yes of course. Once this is merged, I can enable the test again.
>
It looks like the LSP tests are now passing in the vim-win32-installer
CI but failing somewhere else?
Regards,
Yegappan
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Apr 21, 2022, 12:19:06 PM4/21/22
to vim...@googlegroups.com, reply+ACY5DGH54SWRQMPHR5...@reply.github.com, vim/vim, Subscribed
this .(
Bram Moolenaar
Apr 21, 2022, 6:31:01 PM4/21/22
to vim...@googlegroups.com, Christian Brabandt, reply+ACY5DGH54SWRQMPHR5...@reply.github.com
Christian wrote:
> > It looks like the LSP tests are now passing in the vim-win32-installer
> > CI but failing somewhere else?
>
> Yes, it seems test_alot.vim now times out. I have no idea how to debug
> this .(
separately. It's a bit more efficient to run multiple tests without
starting a new Vim instance, but if it makes debugging harder that's
more important to fix than efficiency.
--
Q. What happens to programmers when they die?
A: MS-Windows programmers are reinstalled. C++ programmers become undefined,
anyone who refers to them will die as well. Java programmers reincarnate
after being garbage collected, unless they are in permgen, in which case
they become zombies. Zimbu programmers leave a stack trace that tells us
exactly where they died and how they got there.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
vim-dev ML
Apr 21, 2022, 6:31:18 PM4/21/22
to vim/vim, vim-dev ML, Your activity
Christian wrote:
> > It looks like the LSP tests are now passing in the vim-win32-installer
> > CI but failing somewhere else?
>
> Yes, it seems test_alot.vim now times out. I have no idea how to debug
> this .(
If needed we can split off things from test_alot.vim and run them
separately. It's a bit more efficient to run multiple tests without
starting a new Vim instance, but if it makes debugging harder that's
more important to fix than efficiency.
--
Q. What happens to programmers when they die?
A: MS-Windows programmers are reinstalled. C++ programmers become undefined,
anyone who refers to them will die as well. Java programmers reincarnate
after being garbage collected, unless they are in permgen, in which case
they become zombies. Zimbu programmers leave a stack trace that tells us
exactly where they died and how they got there.
/// \\\
\\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
Apr 22, 2022, 1:04:53 AM4/22/22
to vim/vim, vim-dev ML, Comment
Now, It finally worked. I'll keep an eye on that to see if this happens more often.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you commented.
vim-dev ML
Oct 11, 2022, 3:01:50 AM10/11/22
to vim/vim, vim-dev ML, Your activity
Am 2022-04-21 17:46, schrieb Yegappan Lakshmanan:
> Hi Christian,
>
> On Sun, Apr 17, 2022 at 1:24 PM Christian Brabandt ***@***.***> > Hi Christian,
>
> wrote:
>>
>>
>> On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
>>
>> > Hi Christian,
>> >
>> > On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt ***@***.***> wrote:
>> >
>> >
>> > Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
>> >
>> >
>> >
>> > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
>>
>> Yes of course. Once this is merged, I can enable the test again.
>>
>
>>
>>
>> On So, 17 Apr 2022, Yegappan Lakshmanan wrote:
>>
>> > Hi Christian,
>> >
>> > On Sun, Apr 17, 2022 at 1:15 PM Christian Brabandt ***@***.***> wrote:
>> >
>> >
>> > Hi Yegappan, could that also fix the issue from the vim-win32-installer repository?
>> >
>> >
>> >
>> > Is it possible to do one vim-win32-installer test run with the LSP test enabled again ?
>>
>> Yes of course. Once this is merged, I can enable the test again.
>>
>
> It looks like the LSP tests are now passing in the vim-win32-installer
> CI but failing somewhere else?
Yes, it seems test_alot.vim now times out. I have no idea how to debug
this .(
> CI but failing somewhere else?
Yes, it seems test_alot.vim now times out. I have no idea how to debug
this .(
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Reply all
Reply to author
Forward
0 new messages