[vim/vim] 'autocomplete' behaves inconsistently when recording (PR #20675)

zeertzjq

unread,

2:51 AM (12 hours ago) 2:51 AM

to vim/vim, Subscribed

Problem: If 'autocompletedelay' is non-zero, 'autocomplete' doesn't
work when recording a register (after 9.2.0750).
Solution: Still produce K_COMPLETE_DELAY when recording a register, and
drop it in gotchars_add_byte() instead.

This patch only changes the behavior when recording a register.
Replaying a register with 'autocomplete' still doesn't fully work
regardless of 'autocompletedelay', as 'autocomplete' isn't triggered
when there is pending input.

You can view, comment on, or merge this pull request online at:

https://github.com/vim/vim/pull/20675

Commit Summary

973041e 'autocomplete' behaves inconsistently when recording

File Changes

(3 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

2:56 AM (12 hours ago) 2:56 AM

to vim/vim, Subscribed

zeertzjq left a comment (vim/vim#20675)

Replaying a register with 'autocomplete' still doesn't fully work

Actually it kind of works if one selects the first match using Ctrl-N, as Ctrl-N triggers the same type of completion as 'autocomplete'. However it doesn't work when selecting a match using arrow keys.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

zeertzjq

unread,

3:27 AM (11 hours ago) 3:27 AM

to vim/vim, Subscribed

zeertzjq left a comment (vim/vim#20675)

Hmm, 'autocompletedelay' doesn't work on Windows? All existing tests for 'autocompletedelay' either uses screendumps (which don't work on Windows) or only check if 'autocompletedelay' doesn't interfere with other functionality.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Maxim Kim

unread,

4:06 AM (11 hours ago) 4:06 AM

to vim/vim, Subscribed

habamax left a comment (vim/vim#20675)

Hmm, 'autocompletedelay' doesn't work on Windows? All existing tests for 'autocompletedelay' either uses screendumps (which don't work on Windows) or only check if 'autocompletedelay' doesn't interfere with other functionalities.

It works there (9.2.649), however I didn't try the latest windows build.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Christian Brabandt

unread,

2:27 PM (17 minutes ago) 2:27 PM

to vim/vim, Subscribed

chrisbra left a comment (vim/vim#20675)

thanks

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward