[vim/vim] feat: expose preinserted text in complete_info() (PR #18571)

34 views
Skip to first unread message

girish

unread,
Oct 14, 2025, 8:08:03 AMOct 14
to vim/vim, Subscribed

Useful for defining custom key mappings.

complete_info():

+                  preinserted  |TRUE| if text is pre-inserted.
+                               See |preinserted()|.
+                  preinserted_text
+                               The actual text that is pre-inserted.

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18571

Commit Summary

  • 7743630 Feat: expose preinserted text in complete_info()
  • c3bc92f Add doc

File Changes

(3 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571@github.com>

zeertzjq

unread,
Oct 14, 2025, 8:13:07 AMOct 14
to vim/vim, Subscribed
zeertzjq left a comment (vim/vim#18571)

Doesn't this make the preinserted() function (which was added less than 3 weeks ago) redundant?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/c3401481713@github.com>

girish

unread,
Oct 14, 2025, 12:36:12 PMOct 14
to vim/vim, Subscribed
girishji left a comment (vim/vim#18571)

We have pumvisible() and pum_visible (in complete_info()). It's ok to have redundant ways of getting the same info.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/c3402739492@github.com>

girish

unread,
Oct 14, 2025, 1:06:45 PMOct 14
to vim/vim, Push

@girishji pushed 1 commit.


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/before/c3bc92f43416ae989375c78f2a4365b0803cb8a4/after/f10ae17f4544c33e0df77072105318f2e25bf131@github.com>

girish

unread,
Oct 14, 2025, 1:26:55 PMOct 14
to vim/vim, Push

@girishji pushed 1 commit.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/before/f10ae17f4544c33e0df77072105318f2e25bf131/after/5a6eeff260d4ae518d3203a26af85b0d66691dce@github.com>

girish

unread,
Oct 14, 2025, 7:05:12 PMOct 14
to vim/vim, Push

@girishji pushed 1 commit.

  • 3be902c Removed 'preinserted' field -- users can check for empty string

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/before/5a6eeff260d4ae518d3203a26af85b0d66691dce/after/3be902c74b32490eafcde7fa0cd9cae25823df28@github.com>

girish

unread,
Oct 15, 2025, 4:30:10 AMOct 15
to vim/vim, Push

@girishji pushed 1 commit.

  • 0d1a1a3 Merge branch 'vim:master' into preins2

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/before/3be902c74b32490eafcde7fa0cd9cae25823df28/after/0d1a1a32c06ba2dfe6613bb00c74521cf80a735e@github.com>

girish

unread,
Oct 21, 2025, 3:56:47 AM (12 days ago) Oct 21
to vim/vim, Subscribed
girishji left a comment (vim/vim#18571)

asan build failure does not look legit (Test_crash1_2() timed out). So, this PR is ready to merge.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/c3425271773@github.com>

girish

unread,
Oct 25, 2025, 11:30:49 AM (7 days ago) Oct 25
to vim/vim, Push

@girishji pushed 1 commit.

  • 59b3772 Merge branch 'vim:master' into preins2

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/before/0d1a1a32c06ba2dfe6613bb00c74521cf80a735e/after/59b3772f458dd17f21860540b4c0bbbfcf07a089@github.com>

Christian Brabandt

unread,
Oct 26, 2025, 2:24:41 PM (6 days ago) Oct 26
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18571)

thanks


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/c3448750815@github.com>

Christian Brabandt

unread,
Oct 26, 2025, 2:38:03 PM (6 days ago) Oct 26
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18571)

The documentation was changed for cmdcomplete_info(), but it should go to complete_info(). I'll change it


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/c3448762993@github.com>

Christian Brabandt

unread,
Oct 26, 2025, 2:39:50 PM (6 days ago) Oct 26
to vim/vim, Subscribed

Closed #18571 via ef5bf58.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/issue_event/20511120966@github.com>

girish

unread,
Oct 26, 2025, 3:34:36 PM (6 days ago) Oct 26
to vim/vim, Subscribed
girishji left a comment (vim/vim#18571)

Sorry about the documentation mixup. thanks.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18571/c3448848076@github.com>

Reply all
Reply to author
Forward
0 new messages