[vim/vim] fix(message): fix echowindow wrapping and line order (PR #18874)
glepnir
Problem: Long strings in echowindow wrap one character per line and display in reverse order.
Solution: Use full width for echowindow, reset msg_col after wrap, and increment lnum correctly when creating new lines.
Fix #18750
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/18874
Commit Summary
- e6c10a7 fix(message): fix echowindow wrapping and line order
File Changes
(4 files)
- M src/message.c (40)
- A src/testdir/dumps/Test_echowindow_10.dump (8)
- A src/testdir/dumps/Test_echowindow_11.dump (8)
- M src/testdir/test_messages.vim (13)
Patch Links:
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
h_east
h-east left a comment (vim/vim#18874)Thanks.
The issue of lines being reversed only occurs when the cmdheight option is 2 or greater, so it would be better to explicitly state this condition in the test.
Yes, I understand that cmdheight is set to 2 a few lines earlier(L651).
call term_sendkeys(buf, ":call TwoMessages()\<CR>")
But I think it would be better to add set cmdheight=2 just before the test you added this time to prevent unexpected problems later on.
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
glepnir
@glepnir pushed 1 commit.
- e5cb3df fix echowindow wrapping and line order
—
View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.
glepnir
glepnir left a comment (vim/vim#18874)updated
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#18874)thanks
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
—
Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.