[vim/vim] Refactor some code around f_srand() (PR #15125)

13 views
Skip to first unread message

LemonBoy

unread,
Jun 29, 2024, 4:23:04 AMJun 29
to vim/vim, Subscribed

Nothing too serious, a small refactoring and a bonus.

Move the machine-specific parts to os_mswin and os_unix.
Implement a simple fallback for Windows (works on 10 or later).


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/15125

Commit Summary

  • a0e977c Refactor some code around f_srand()

File Changes

(5 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15125@github.com>

LemonBoy

unread,
Jun 29, 2024, 4:27:51 AMJun 29
to vim/vim, Push

@LemonBoy pushed 1 commit.

  • f757b4f Use char_u for the buffer type


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15125/before/a0e977c886641a9022cf19d5e75b6f6595e7c43e/after/f757b4f73a6643f49164787558f3d27cea2236d8@github.com>

Christian Brabandt

unread,
Jul 4, 2024, 5:51:06 AMJul 4
to vim/vim, Subscribed

Thanks. The change on MS-Windows, do we need to care for Windows 8 support?


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15125/c2208570658@github.com>

LemonBoy

unread,
Jul 4, 2024, 6:24:14 AMJul 4
to vim/vim, Subscribed

The change on MS-Windows, do we need to care for Windows 8 support?

On systems older than Windows 10 this change is a no-op and libsodium (if available) is used instead, adding a fallback using RtlGenRandom or similar takes too many lines for little or no gain.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15125/c2208633064@github.com>

Christian Brabandt

unread,
Jul 4, 2024, 7:19:27 AMJul 4
to vim/vim, Subscribed

alright, thanks then.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15125/c2208722691@github.com>

Christian Brabandt

unread,
Jul 4, 2024, 7:24:20 AMJul 4
to vim/vim, Subscribed

Closed #15125 via 9987fe8.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/15125/issue_event/13393490991@github.com>

Reply all
Reply to author
Forward
0 new messages