Commit: runtime(dockerfile): do not set commentstring in syntax script

7 views
Skip to first unread message

Christian Brabandt

unread,
Dec 20, 2024, 2:00:14 PM12/20/24
to vim...@googlegroups.com
runtime(dockerfile): do not set commentstring in syntax script

Commit: https://github.com/vim/vim/commit/70881ba195d267d01df912294ddc5b5d525bba3d
Author: Christian Brabandt <c...@256bit.org>
Date: Fri Dec 20 19:53:55 2024 +0100

runtime(dockerfile): do not set commentstring in syntax script

fixes: https://github.com/vim/vim/issues/16268

Signed-off-by: Christian Brabandt <c...@256bit.org>

diff --git a/runtime/ftplugin/dockerfile.vim b/runtime/ftplugin/dockerfile.vim
index 2e3c447b5..e45bf4c1d 100644
--- a/runtime/ftplugin/dockerfile.vim
+++ b/runtime/ftplugin/dockerfile.vim
@@ -1,7 +1,7 @@
" Vim filetype plugin
" Language: Dockerfile
" Maintainer: Honza Pokorny <http://honza.ca>
-" Last Change: 2014 Aug 29
+" Last Change: 2024 Dec 20

" Only do this when not done yet for this buffer
if exists("b:did_ftplugin")
@@ -11,6 +11,6 @@ endif
" Don't load another plugin for this buffer
let b:did_ftplugin = 1

-let b:undo_ftplugin = "setl commentstring<"
-
setlocal commentstring=#\ %s
+
+let b:undo_ftplugin = "setl commentstring<"
diff --git a/runtime/syntax/dockerfile.vim b/runtime/syntax/dockerfile.vim
index 6ec71fcdb..f1d612f4a 100644
--- a/runtime/syntax/dockerfile.vim
+++ b/runtime/syntax/dockerfile.vim
@@ -1,6 +1,6 @@
" dockerfile.vim - Syntax highlighting for Dockerfiles
" Maintainer: Honza Pokorny <https://honza.ca>
-" Last Change: 2024 Jul 03
+" Last Change: 2024 Dec 20
" License: BSD

" https://docs.docker.com/engine/reference/builder/
@@ -35,7 +35,6 @@ syntax region dockerfileShell contained keepend start=/ / skip=/ \\_./ end=/
syntax region dockerfileValue contained keepend start=/ / skip=/ \\_./ end=/ $/ contains=dockerfileString

syntax region dockerfileComment start=/ ^\s*#/ end=/ $/ contains=@Spell
-set commentstring=#\ %s

hi def link dockerfileString String
hi def link dockerfileKeyword Keyword
Reply all
Reply to author
Forward
0 new messages