[vim/vim] winlayout() returns different results depending on the screen width (#5251)

[Yegappan Lakshmanan]

The quickfix test using winlayout() is failing when run on windows with width greater
than 80 columns. Use another method to assert that the help window is the top window.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/5251

Commit Summary

• Instead of using winlayout(), use a different method to verify that the help window is the top window

File Changes

• M src/testdir/test_quickfix.vim (6)

Patch Links:

• https://github.com/vim/vim/pull/5251.patch
• https://github.com/vim/vim/pull/5251.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[Bram Moolenaar]

I had already included #5244 before I saw this pull request. Is this one better, or can we just keep what we have now?

[Yegappan Lakshmanan]

Hi Bram,

On Tue, Nov 19, 2019 at 2:25 PM Bram Moolenaar <vim-dev...@256bit.org> wrote:

I had already included #5244 before I saw this pull request. Is this one better, or can we just keep what we have now?

We can keep what is there now. If we run into this issue with winlayout() again in the

future in some other environment (with different terminal or terminal size), we can then

use this.

- Yegappan

 

[vim-dev ML]

Hi Bram,

On Tue, Nov 19, 2019 at 2:25 PM Bram Moolenaar <vim-dev...@256bit.org>
wrote:

> I had already included #5244 <https://github.com/vim/vim/pull/5244>

> before I saw this pull request. Is this one better, or can we just keep
> what we have now?
>
>
>
We can keep what is there now. If we run into this issue with winlayout()
again in the
future in some other environment (with different terminal or terminal
size), we can then
use this.

- Yegappan

[Yegappan Lakshmanan]

@yegappan pushed 1 commit.

• 36b8e54 Instead of using winlayout(), use a different method to verify that the help window is the top window

—
You are receiving this because you are subscribed to this thread.

View it on GitHub or unsubscribe.

[Codecov]

Codecov Report

Merging #5251 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@

##           master    #5251      +/-   ##

==========================================

+ Coverage   82.11%   82.12%   +<.01%     

==========================================

  Files         134      134              

  Lines      147429   147429              

==========================================

+ Hits       121064   121078      +14     

+ Misses      26365    26351      -14

Impacted Files	Coverage Δ
src/profiler.c	94.11% <0%> (-0.57%)	⬇️
src/gui.c	63.74% <0%> (-0.06%)	⬇️
src/terminal.c	81.7% <0%> (-0.04%)	⬇️
src/window.c	88.3% <0%> (+0.03%)	⬆️
src/os_unix.c	63.5% <0%> (+0.04%)	⬆️
src/gui_gtk_x11.c	58.16% <0%> (+0.04%)	⬆️
src/mouse.c	76.6% <0%> (+0.08%)	⬆️
src/if_xcmdsrv.c	86.17% <0%> (+0.17%)	⬆️
src/ui.c	71.33% <0%> (+1.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a075490...36b8e54. Read the comment docs.

—
You are receiving this because you commented.

[Yegappan Lakshmanan]

This issue is already fixed by PR #5244.

—
You are receiving this because you commented.

[Yegappan Lakshmanan]

Closed #5251.

—
You are receiving this because you commented.