[vim/vim] test suite races when run with parallel make (PR #20082)
Jesse Rosenstock
Problem: Running "make test" with -jN causes spurious failures because
the old-style tests share filenames (test.ok, test.out, X*,
viminfo) in the working directory.
Solution: Add .NOTPARALLEL to the testdir Makefile to prevent parallel
execution of tests (Jesse Rosenstock).
Co-authored-by: Gemini
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20082
Commit Summary
- ce3b0e9 test suite races when run with parallel make
File Changes
(1 file)
- M src/testdir/Makefile (5)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20082)is this portable?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Jesse Rosenstock
jmr left a comment (vim/vim#20082)is this portable?
Yes. In non-GNU make, it will just create a target with no prereqs and an empty recipe.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.
Jesse Rosenstock
jmr left a comment (vim/vim#20082)Slight correction: -j/.NOTPARALLEL is even in POSIX.1-2024.
So more standard than I thought, but still works with older make implementations.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.