[vim/vim] u_read_undo() leaks the file name when the undo file owner differs (PR #20987)
Samuel Schlesinger
Problem
When the owner of an undo file differs from the owner of the text file and
the current user, u_read_undo() returns without freeing the file name it
allocated with u_get_undo_file_name(). Every other exit frees it under
the "theend" label; this early return sits before the file pointer is
initialized, so it cannot use that label.
Solution
Free the file name before returning.
Noticed while reworking #20942; independent of that change, so sent
separately.
AI assistance is acknowledged with Co-Authored-By trailers on the commit,
per AGENTS.md.
You can view, comment on, or merge this pull request online at:
https://github.com/vim/vim/pull/20987
Commit Summary
- 8dd5988 u_read_undo() leaks the file name when the undo file owner differs
File Changes
(1 file)
- M src/undo.c (1)
Patch Links:
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Christian Brabandt
chrisbra left a comment (vim/vim#20987)thanks
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.