[vim/vim] Fix: remove hl-ComplMatchIns usage during "preinsert" (PR #18254)

15 views
Skip to first unread message

girish

unread,
Sep 9, 2025, 11:04:12 AM (4 days ago) Sep 9
to vim/vim, Subscribed

When "preinsert" is included in 'completeopt', only the hl-PreInsert highlight group should be applied. Previously, hl-ComplMatchIns was used when autocompletion was not enabled.

Related to #18213.


You can view, comment on, or merge this pull request online at:

  https://github.com/vim/vim/pull/18254

Commit Summary

  • e12aecf Fix: remove hl-ComplMatchIns usage during "preinsert"

File Changes

(4 files)

Patch Links:


Reply to this email directly, view it on GitHub.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18254@github.com>

Shane-XB-Qian

unread,
Sep 9, 2025, 1:27:47 PM (4 days ago) Sep 9
to vim/vim, Subscribed
Shane-XB-Qian left a comment (vim/vim#18254)
perhaps it should be named as ComplPreIns, regardless to someone was arguing, but just I felt it perhaps be,
// and I would not use this feat either, lsp had inlinecompletion spec, seems such things looked similar.
// fyi and btw: I am not a tester :smile: vs just was boring :sweat_smile: so just a friendly suggestion.

--
shane.xb.qian


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18254/c3271650452@github.com>

girish

unread,
Sep 9, 2025, 4:09:19 PM (4 days ago) Sep 9
to vim/vim, Push

@girishji pushed 1 commit.


View it on GitHub or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18254/before/e12aecfee10afcf104520d53367a116f277d231c/after/28dcfd17c444522cd2c2eb39214b313c15888ea0@github.com>

Christian Brabandt

unread,
Sep 10, 2025, 4:07:28 AM (3 days ago) Sep 10
to vim/vim, Subscribed

Closed #18254 via 2525c56.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18254/issue_event/19607124523@github.com>

Christian Brabandt

unread,
Sep 10, 2025, 4:07:52 AM (3 days ago) Sep 10
to vim/vim, Subscribed
chrisbra left a comment (vim/vim#18254)

thanks


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18254/c3273810053@github.com>

girish

unread,
Sep 10, 2025, 9:44:35 AM (3 days ago) Sep 10
to vim/vim, Subscribed
girishji left a comment (vim/vim#18254)

Thanks.


Reply to this email directly, view it on GitHub.

You are receiving this because you are subscribed to this thread.Message ID: <vim/vim/pull/18254/c3275046084@github.com>

Reply all
Reply to author
Forward
0 new messages